Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1454615

Re: [PATCH 0077/1285] Replace numeric parameter like 0444 with macro

Show all headers | View raw

On Tue 2016-08-02 18:38:55, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
> 
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>

Sorry, the macros just make it _less_ readable, because you do chmod
666, not chmod S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH.

NAK.
							Pavel
							
> -static DEVICE_ATTR(control, 0644, control_show, control_store);
> +static DEVICE_ATTR(control, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, control_show, control_store);

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0077/1285] Replace numeric parameter like 0444 with macro Baole Ni <baolex.ni@intel.com> - 2016-08-02 13:30 +0200
  Re: [PATCH 0077/1285] Replace numeric parameter like 0444 with macro Pavel Machek <pavel@ucw.cz> - 2016-08-02 16:50 +0200
    Re: [PATCH 0077/1285] Replace numeric parameter like 0444 with macro Michal Kubecek <mkubecek@suse.cz> - 2016-08-03 09:30 +0200

csiph-web