Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1454561

Re: [PATCH 0234/1285] Replace numeric parameter like 0444 with macro

Show all headers | View raw

On 08/02/2016 03:51 AM, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>
> ---
>   drivers/hwmon/abituguru.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/abituguru.c b/drivers/hwmon/abituguru.c
> index 7a09c16..84d7070 100644
> --- a/drivers/hwmon/abituguru.c
> +++ b/drivers/hwmon/abituguru.c
> @@ -194,7 +194,7 @@ MODULE_PARM_DESC(pwms, "Number of PWMs on the uGuru "
>
>   /* Default verbose is 2, since this driver is still in the testing phase */
>   static int verbose = 2;
> -module_param(verbose, int, 0644);
> +module_param(verbose, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);

S_IRUGO is quite useful, such as in "S_IRUGO | S_IWUSR".

Note that I cut down the excessive Cc:. Please don't do that again,
and please submit a single patch for the hwmon subsystem.

Guenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0234/1285] Replace numeric parameter like 0444 with macro Baole Ni <baolex.ni@intel.com> - 2016-08-02 13:40 +0200
  Re: [PATCH 0234/1285] Replace numeric parameter like 0444 with macro Guenter Roeck <linux@roeck-us.net> - 2016-08-02 16:30 +0200

csiph-web