Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1454558

[PATCH 1038/1285] Replace numeric parameter like 0444 with macro

Show all headers | View raw

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 fs/ext4/crypto.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ext4/crypto.c b/fs/ext4/crypto.c
index 6a6c273..40877aa 100644
--- a/fs/ext4/crypto.c
+++ b/fs/ext4/crypto.c
@@ -42,10 +42,10 @@
 static unsigned int num_prealloc_crypto_pages = 32;
 static unsigned int num_prealloc_crypto_ctxs = 128;
 
-module_param(num_prealloc_crypto_pages, uint, 0444);
+module_param(num_prealloc_crypto_pages, uint, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(num_prealloc_crypto_pages,
 		 "Number of crypto pages to preallocate");
-module_param(num_prealloc_crypto_ctxs, uint, 0444);
+module_param(num_prealloc_crypto_ctxs, uint, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(num_prealloc_crypto_ctxs,
 		 "Number of crypto contexts to preallocate");
 
-- 
2.9.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1038/1285] Replace numeric parameter like 0444 with macro Baole Ni <baolex.ni@intel.com> - 2016-08-02 16:30 +0200
  Re: [PATCH 1038/1285] Replace numeric parameter like 0444 with macro Theodore Ts'o <tytso@mit.edu> - 2016-08-02 23:20 +0200

csiph-web