Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1454401

Re: [PATCH v2] powerpc/32: fix csum_partial_copy_generic()

From Segher Boessenkool <segher@kernel.crashing.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2] powerpc/32: fix csum_partial_copy_generic()
Date 2016-08-02 15:40 +0200
Message-ID <s1I5l-54A-87@gated-at.bofh.it> (permalink)
References <s1Gwy-3Wp-49@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, Aug 02, 2016 at 10:07:05AM +0200, Christophe Leroy wrote:
> commit 7aef4136566b0 ("powerpc32: rewrite csum_partial_copy_generic()
> based on copy_tofrom_user()") introduced a bug when destination
> address is odd and initial csum is not null
> 
> In that (rare) case the initial csum value has to be rotated one byte
> as well as the resulting value is
> 
> This patch also fixes related comments
> 
> Fixes: 7aef4136566b0 ("powerpc32: rewrite csum_partial_copy_generic()
> based on copy_tofrom_user()")
> Cc: stable@vger.kernel.org
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> ---
>  v2: updated comments as suggested by Segher

Thanks.  It looks good to me now.


Segher

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] powerpc/32: fix csum_partial_copy_generic() Christophe Leroy <christophe.leroy@c-s.fr> - 2016-08-02 14:00 +0200
  Re: [PATCH v2] powerpc/32: fix csum_partial_copy_generic() Segher Boessenkool <segher@kernel.crashing.org> - 2016-08-02 15:40 +0200
  Re: [PATCH v2] powerpc/32: fix csum_partial_copy_generic() Segher Boessenkool <segher@kernel.crashing.org> - 2016-08-02 16:40 +0200
  Re: [PATCH v2] powerpc/32: fix csum_partial_copy_generic() Scott Wood <oss@buserror.net> - 2016-08-04 06:00 +0200
    Re: [PATCH v2] powerpc/32: fix csum_partial_copy_generic() Alessio Igor Bogani <alessio.bogani@elettra.eu> - 2016-08-04 08:40 +0200
      Re: [PATCH v2] powerpc/32: fix csum_partial_copy_generic() Michael Ellerman <mpe@ellerman.id.au> - 2016-08-05 09:00 +0200
        Re: [PATCH v2] powerpc/32: fix csum_partial_copy_generic() Christophe Leroy <christophe.leroy@c-s.fr> - 2016-08-05 09:30 +0200
          Re: [PATCH v2] powerpc/32: fix csum_partial_copy_generic() Michael Ellerman <mpe@ellerman.id.au> - 2016-08-05 11:40 +0200
  Re: [v2] powerpc/32: fix csum_partial_copy_generic() Michael Ellerman <patch-notifications@ellerman.id.au> - 2016-08-10 21:50 +0200

csiph-web