Re: [PATCH 2/2 v4] perf sched: adapt TASK_STATE_TO_CHAR_STR to the latest kernel

From	Masami Hiramatsu <mhiramat@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2 v4] perf sched: adapt TASK_STATE_TO_CHAR_STR to the latest kernel
Date	2016-08-02 15:30 +0200
Message-ID	<s1HVF-50V-85@gated-at.bofh.it> (permalink)
References	<s1dbb-1vs-15@gated-at.bofh.it> <s1dbb-1vs-13@gated-at.bofh.it> <s1lV8-73w-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 1 Aug 2016 07:58:19 -0600
David Ahern <dsahern@gmail.com> wrote:

> On 7/31/16 10:30 PM, Tomoki Sekiyama wrote:
> > Update TASK_STATE_TO_CHAR_STR macro to one from sched.h in the latest
> > kernel, where 'N' and 'n' are introduced, 'X' and 'Z' are swapped.
> >
> > Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama.qu@hitachi.com>
> > Fixes: cdce9d738b91e ("perf sched: Add sched latency profiling")
> 
> Wrong Fixes tag for this change.
> 
> This is really an update based on kernel changes, the last one being 
> 7dc603c9028ea.

Except for the above mistake, I'm also OK for the code.

Thanks,

> 
> 
> > Cc: Jiri Olsa <jolsa@kernel.org>
> > Cc: David Ahern <dsahern@gmail.com>
> > Cc: Namhyung Kim <namhyung@kernel.org>
> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > Cc: Masami Hiramatsu <mhiramat@kernel.org>
> > ---
> > Changes from v3:
> >   Added Fixes:
> >   Split patch into 2 pieces.
> >
> >  tools/perf/builtin-sched.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
> > index ce9bef6..5776263 100644
> > --- a/tools/perf/builtin-sched.c
> > +++ b/tools/perf/builtin-sched.c
> > @@ -70,7 +70,7 @@ struct sched_atom {
> >  	struct task_desc	*wakee;
> >  };
> >
> > -#define TASK_STATE_TO_CHAR_STR "RSDTtZXxKWP"
> > +#define TASK_STATE_TO_CHAR_STR "RSDTtXZxKWPNn"
> >
> >  enum thread_state {
> >  	THREAD_SLEEPING = 0,
> >
> 
> Acked-by: David Ahern <dsahern@gmail.com>


-- 
Masami Hiramatsu <mhiramat@kernel.org>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2 v4] perf sched: adapt TASK_STATE_TO_CHAR_STR to the latest kernel Tomoki Sekiyama <tomoki.sekiyama.qu@hitachi.com> - 2016-08-01 06:40 +0200
  Re: [PATCH 2/2 v4] perf sched: adapt TASK_STATE_TO_CHAR_STR to the  latest kernel David Ahern <dsahern@gmail.com> - 2016-08-01 16:00 +0200
    Re: [PATCH 2/2 v4] perf sched: adapt TASK_STATE_TO_CHAR_STR to the  latest kernel Masami Hiramatsu <mhiramat@kernel.org> - 2016-08-02 15:30 +0200

csiph-web