Re: [PATCHv2 1/7] tools lib: Add bitmap_alloc function

From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCHv2 1/7] tools lib: Add bitmap_alloc function
Date	2016-08-02 16:20 +0200
Message-ID	<s1HM0-4Xn-97@gated-at.bofh.it> (permalink)
References	<s1pYK-1pc-11@gated-at.bofh.it> <s1pYK-1pc-9@gated-at.bofh.it> <s1rxv-2ia-1@gated-at.bofh.it> <s1El3-2B6-13@gated-at.bofh.it> <s1GmT-3Sw-79@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Em Tue, Aug 02, 2016 at 01:33:02PM +0200, Jiri Olsa escreveu:
> ---
> Adding bitmap_alloc function to dynamically allocate bitmap.

Why should we deviate from the kernel way of doing things, where, AFAIK,
there is no such bitmap_alloc() function?

[acme@jouet linux]$ find . -type f | xargs grep -w bitmap_alloc
[acme@jouet linux]$ 

- Arnaldo
 
> Link: http://lkml.kernel.org/n/tip-ictn3ke5ewrzwyn8webfeai9@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
>  tools/include/linux/bitmap.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/tools/include/linux/bitmap.h b/tools/include/linux/bitmap.h
> index 28f5493da491..60c44b615902 100644
> --- a/tools/include/linux/bitmap.h
> +++ b/tools/include/linux/bitmap.h
> @@ -3,6 +3,7 @@
>  
>  #include <string.h>
>  #include <linux/bitops.h>
> +#include <stdlib.h>
>  
>  #define DECLARE_BITMAP(name,bits) \
>  	unsigned long name[BITS_TO_LONGS(bits)]
> @@ -65,4 +66,13 @@ static inline int test_and_set_bit(int nr, unsigned long *addr)
>  	return (old & mask) != 0;
>  }
>  
> +/**
> + * bitmap_alloc - Allocate bitmap
> + * @nr: Bit to set
> + */
> +static inline unsigned long *bitmap_alloc(int nbits)
> +{
> +	return calloc(1, BITS_TO_LONGS(nbits) * sizeof(unsigned long));
> +}
> +
>  #endif /* _PERF_BITOPS_H */
> -- 
> 2.4.11

Thread

[PATCH 1/7] tools lib: Add bitmap_alloc function Jiri Olsa <jolsa@kernel.org> - 2016-08-01 20:20 +0200
  Re: [PATCH 1/7] tools lib: Add bitmap_alloc function David Ahern <dsahern@gmail.com> - 2016-08-01 22:00 +0200
    Re: [PATCH 1/7] tools lib: Add bitmap_alloc function Jiri Olsa <jolsa@redhat.com> - 2016-08-02 11:40 +0200
      [PATCHv2 1/7] tools lib: Add bitmap_alloc function Jiri Olsa <jolsa@redhat.com> - 2016-08-02 13:50 +0200
        Re: [PATCHv2 1/7] tools lib: Add bitmap_alloc function Jiri Olsa <jolsa@redhat.com> - 2016-08-02 15:20 +0200
        Re: [PATCHv2 1/7] tools lib: Add bitmap_alloc function Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-08-02 16:20 +0200
        [tip:perf/urgent] tools lib: Add bitmap_alloc function tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-08-04 11:20 +0200

csiph-web