Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1453730
| From | Juri Lelli <juri.lelli@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC][PATCH 1/7] cpufreq / sched: Make schedutil access utilization data directly |
| Date | 2016-08-02 12:40 +0200 |
| Message-ID | <s1Fhd-3ao-19@gated-at.bofh.it> (permalink) |
| References | <s18Ex-6NS-1@gated-at.bofh.it> <s18Ex-6NS-9@gated-at.bofh.it> <s1re9-2an-13@gated-at.bofh.it> <s1vrr-5aK-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi,
On 02/08/16 01:46, Rafael J. Wysocki wrote:
> On Monday, August 01, 2016 12:28:50 PM Steve Muckle wrote:
> > On Mon, Aug 01, 2016 at 01:34:36AM +0200, Rafael J. Wysocki wrote:
> > ...
> > > Index: linux-pm/kernel/sched/cpufreq_schedutil.c
> > > ===================================================================
> > > --- linux-pm.orig/kernel/sched/cpufreq_schedutil.c
> > > +++ linux-pm/kernel/sched/cpufreq_schedutil.c
> > > @@ -144,17 +144,47 @@ static unsigned int get_next_freq(struct
> > > return cpufreq_driver_resolve_freq(policy, freq);
> > > }
> > >
> > > -static void sugov_update_single(struct update_util_data *hook, u64 time,
> > > - unsigned long util, unsigned long max)
> > > +static void sugov_get_util(unsigned long *util, unsigned long *max)
> > > +{
> > > + unsigned long dl_util, dl_max;
> > > + unsigned long cfs_util, cfs_max;
> > > + int cpu = smp_processor_id();
> > > + struct dl_bw *dl_bw = dl_bw_of(cpu);
> > > + struct rq *rq = this_rq();
> > > +
> > > + if (rt_prio(current->prio)) {
> > > + *util = ULONG_MAX;
> > > + return;
> > > + }
> > > +
> > > + dl_max = dl_bw_cpus(cpu) << 20;
> > > + dl_util = dl_bw->total_bw;
> > > +
> > > + cfs_max = rq->cpu_capacity_orig;
> > > + cfs_util = min(rq->cfs.avg.util_avg, cfs_max);
> > > +
> > > + if (cfs_util * dl_max > dl_util * cfs_max) {
> > > + *util = cfs_util;
> > > + *max = cfs_max;
> > > + } else {
> > > + *util = dl_util;
> > > + *max = dl_max;
> > > + }
> > > +}
> >
> > Last Friday I had put together a similar patch based on Peter's. I need
> > the flags field for the remote wakeup support. My previous plan,
> > installing a late callback in check_preempt_curr that gets requested
> > from the earlier existing CFS callback, was not working out since those
> > two events don't always match up 1:1.
> >
> > Anyway one way that my patch differed was that I had used the flags
> > field to keep the behavior the same for both RT and DL.
Do you mean "go to max" policy for both, until proper policies will be
implemented in the future?
> That happens
> > later on in this series for RT but the DL policy is modified as above.
> > Can the DL policy be left as-is and discussed/modified in a separate
> > series?
Not that we want to start discussing this point now, if we postpone the
change for later, but I just wanted to point out a difference w.r.t.
what the schedfreq thing was doing: it used to sum contributions from
the different classes, instead of taking the max. We probably never
really discussed on the list what is the right thing to do, though.
Best,
- Juri
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC][PATCH 0/7] cpufreq / sched: cpufreq_update_util() flags and iowait boosting "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-08-01 01:50 +0200
[RFC][PATCH 4/7] cpufreq / sched: Add flags argument to cpufreq_update_util() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-08-01 01:50 +0200
Re: [RFC][PATCH 4/7] cpufreq / sched: Add flags argument to cpufreq_update_util() Dominik Brodowski <linux@dominikbrodowski.net> - 2016-08-01 10:00 +0200
Re: [RFC][PATCH 4/7] cpufreq / sched: Add flags argument to cpufreq_update_util() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-08-01 17:10 +0200
Re: [RFC][PATCH 4/7] cpufreq / sched: Add flags argument to cpufreq_update_util() Steve Muckle <steve.muckle@linaro.org> - 2016-08-01 22:30 +0200
Re: [RFC][PATCH 4/7] cpufreq / sched: Add flags argument to cpufreq_update_util() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-08-02 01:50 +0200
Re: [RFC][PATCH 4/7] cpufreq / sched: Add flags argument to cpufreq_update_util() Steve Muckle <steve.muckle@linaro.org> - 2016-08-02 04:10 +0200
[RFC][PATCH 3/7] cpufreq / sched: Check cpu_of(rq) in cpufreq_update_util() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-08-01 01:50 +0200
Re: [RFC][PATCH 3/7] cpufreq / sched: Check cpu_of(rq) in cpufreq_update_util() Dominik Brodowski <linux@dominikbrodowski.net> - 2016-08-01 10:00 +0200
Re: [RFC][PATCH 3/7] cpufreq / sched: Check cpu_of(rq) in cpufreq_update_util() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-08-01 17:10 +0200
Re: [RFC][PATCH 3/7] cpufreq / sched: Check cpu_of(rq) in cpufreq_update_util() Steve Muckle <steve.muckle@linaro.org> - 2016-08-01 21:50 +0200
Re: [RFC][PATCH 3/7] cpufreq / sched: Check cpu_of(rq) in cpufreq_update_util() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-08-02 01:50 +0200
[RFC][PATCH 1/7] cpufreq / sched: Make schedutil access utilization data directly "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-08-01 01:50 +0200
Re: [RFC][PATCH 1/7] cpufreq / sched: Make schedutil access utilization data directly Steve Muckle <steve.muckle@linaro.org> - 2016-08-01 21:40 +0200
Re: [RFC][PATCH 1/7] cpufreq / sched: Make schedutil access utilization data directly "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-08-02 02:10 +0200
Re: [RFC][PATCH 1/7] cpufreq / sched: Make schedutil access utilization data directly Juri Lelli <juri.lelli@arm.com> - 2016-08-02 12:40 +0200
Re: [RFC][PATCH 1/7] cpufreq / sched: Make schedutil access utilization data directly Steve Muckle <steve.muckle@linaro.org> - 2016-08-02 16:40 +0200
Re: [RFC][PATCH 1/7] cpufreq / sched: Make schedutil access utilization data directly Juri Lelli <juri.lelli@arm.com> - 2016-08-02 17:00 +0200
Re: [RFC][PATCH 1/7] cpufreq / sched: Make schedutil access utilization data directly Peter Zijlstra <peterz@infradead.org> - 2016-08-08 12:40 +0200
[RFC][PATCH 2/7] cpufreq / sched: Drop cpufreq_trigger_update() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-08-01 01:50 +0200
[RFC][PATCH 5/7] cpufreq / sched: UUF_IO flag to indicate iowait condition "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-08-01 01:50 +0200
Re: [RFC][PATCH 5/7] cpufreq / sched: UUF_IO flag to indicate iowait condition Steve Muckle <steve.muckle@linaro.org> - 2016-08-02 03:30 +0200
Re: [RFC][PATCH 5/7] cpufreq / sched: UUF_IO flag to indicate iowait condition "Rafael J. Wysocki" <rafael@kernel.org> - 2016-08-02 03:50 +0200
Re: [RFC][PATCH 5/7] cpufreq / sched: UUF_IO flag to indicate iowait condition Steve Muckle <steve.muckle@linaro.org> - 2016-08-03 00:30 +0200
Re: [RFC][PATCH 5/7] cpufreq / sched: UUF_IO flag to indicate iowait condition "Rafael J. Wysocki" <rafael@kernel.org> - 2016-08-03 00:50 +0200
Re: [RFC][PATCH 5/7] cpufreq / sched: UUF_IO flag to indicate iowait condition Steve Muckle <steve.muckle@linaro.org> - 2016-08-04 04:30 +0200
Re: [RFC][PATCH 5/7] cpufreq / sched: UUF_IO flag to indicate iowait condition "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-08-04 23:20 +0200
Re: [RFC][PATCH 5/7] cpufreq / sched: UUF_IO flag to indicate iowait condition Steve Muckle <steve.muckle@linaro.org> - 2016-08-05 00:10 +0200
Re: [RFC][PATCH 5/7] cpufreq / sched: UUF_IO flag to indicate iowait condition "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-08-06 23:20 +0200
[RFC][PATCH 7/7] cpufreq: intel_pstate: Change P-state selection algorithm for Core "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-08-01 01:50 +0200
RE: [RFC][PATCH 7/7] cpufreq: intel_pstate: Change P-state selection algorithm for Core "Doug Smythies" <dsmythies@telus.net> - 2016-08-04 09:00 +0200
Re: [RFC][PATCH 7/7] cpufreq: intel_pstate: Change P-state selection algorithm for Core "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-08-06 23:50 +0200
RE: [RFC][PATCH 7/7] cpufreq: intel_pstate: Change P-state selection algorithm for Core "Doug Smythies" <dsmythies@telus.net> - 2016-08-09 19:20 +0200
[RFC][PATCH 6/7] cpufreq: schedutil: Add iowait boosting "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-08-01 01:50 +0200
Re: [RFC][PATCH 6/7] cpufreq: schedutil: Add iowait boosting Steve Muckle <steve.muckle@linaro.org> - 2016-08-02 03:40 +0200
Re: [RFC][PATCH 6/7] cpufreq: schedutil: Add iowait boosting "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-08-03 01:00 +0200
RE: [RFC][PATCH 0/7] cpufreq / sched: cpufreq_update_util() flags and iowait boosting "Doug Smythies" <dsmythies@telus.net> - 2016-08-01 17:30 +0200
Re: [RFC][PATCH 0/7] cpufreq / sched: cpufreq_update_util() flags and iowait boosting "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-08-01 18:30 +0200
Re: [RFC][PATCH 0/7] cpufreq / sched: cpufreq_update_util() flags and iowait boosting Peter Zijlstra <peterz@infradead.org> - 2016-08-08 13:10 +0200
Re: [RFC][PATCH 0/7] cpufreq / sched: cpufreq_update_util() flags and iowait boosting "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-08-08 15:00 +0200
csiph-web