Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1452537

Re: [PATCH 1/1] UBSAN: use uppercase K to format a kernel pointer

Show key headers only | View raw

On Fri, 2016-07-29 at 13:10 +0200, Nicolas Iooss wrote:
> handle_object_size_mismatch() used %pk to format a kernel pointer in
> pr_err().  This seems to be a misspelling for %pK.

Thanks


> diff --git a/lib/ubsan.c b/lib/ubsan.c
[]
> @@ -308,7 +308,7 @@ static void handle_object_size_mismatch(struct
> type_mismatch_data *data,
>  		return;
>  
>  	ubsan_prologue(&data->location, &flags);
> -	pr_err("%s address %pk with insufficient space\n",
> +	pr_err("%s address %pK with insufficient space\n",
>  		type_check_kinds[data->type_check_kind],
>  		(void *) ptr);
>  	pr_err("for an object of type %s\n", data->type->type_name);

Maybe change this to a single output line:

	pr_err("%s address %pK with insufficient space for an object of type %s\n",
	       type_check_kinds[data->type_check_kind], (void *)ptr,
	       data->type->type_name);

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] UBSAN: use uppercase K to format a kernel pointer Nicolas Iooss <nicolas.iooss_linux@m4x.org> - 2016-07-29 13:20 +0200
  Re: [PATCH 1/1] UBSAN: use uppercase K to format a kernel pointer Joe Perches <joe@perches.com> - 2016-07-29 22:00 +0200
    Re: [PATCH 1/1] UBSAN: use uppercase K to format a kernel pointer Nicolas Iooss <nicolas.iooss_linux@m4x.org> - 2016-07-30 10:30 +0200
      [PATCH 1/1] UBSAN: fix typo in format string Nicolas Iooss <nicolas.iooss_linux@m4x.org> - 2016-07-30 10:40 +0200

csiph-web