Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1452523

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

Path csiph.com!feeder.erje.net!1.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news-1.dfn.de!news.dfn.de!fu-berlin.de!bofh.it!news.nic.it!robomod
From David Ahern <dsa@cumulusnetworks.com>
Newsgroups linux.kernel
Subject Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace
Date Fri, 29 Jul 2016 21:20:02 +0200
Message-ID <s0lua-qL-5@gated-at.bofh.it> (permalink)
References <s07rb-83j-1@gated-at.bofh.it> <s07AR-89U-1@gated-at.bofh.it> <s0gNP-5Ib-7@gated-at.bofh.it> <s0jiF-7fv-3@gated-at.bofh.it>
X-Original-To John Stultz <john.stultz@linaro.org>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=eo09ytK3eepCttAWI1LqdS5WRepAgejvPwCNrRpLZjg=; b=Lr3ulSEEDuUaWI+iH5XpgdTJA4sCeBfyAWn6UHnKV/3kqKLMECPGtcI6InDeYDL7Qd 96mJfu6JJ7QO5pASmUGZnJzWeqQYXUD9rZyDF/U5sUlREE5nYmWZIuuFOQJ9ie0OkkI0 GDQ1w95P1QTjY3KmCcoG1stWL147Xt1b+RZWA=
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=eo09ytK3eepCttAWI1LqdS5WRepAgejvPwCNrRpLZjg=; b=fkxQW/02vyGnWILu3Dsmj5B1/HfrTDBF7DJFoH9ixLCKbyDjVHeVvK0nfbXXG25pzj 3bgOabXl/DKNQx+XPlumnDrZFDkJ0hXQXjtyGb3avKJyayhZ0QleSVahxdKasEEnt3ZA 7OFgeosTg3Prj5F6mdO7Zud3nT3pGmLVakkazc1GWV+SeboL5NqVFxmAZZ6N30mT7Xzz xXpDjBzSvO5YShd1MFequDVFHW7/PWADw0bdRDWhZaa2AYG8YWyQyBnJSSzVxgXBVr4j HhtGQSsJgkAVm2TvwMXGMjmigDovtlt/PRz7FIGw/bmStFTWmskbPBKTmyqDog8+S1/V ClbQ==
X-Gm-Message-State AEkoouvaEF2E/Ys+4a0kSwGfIhtRSuwWSQi+t/ANSHDvdoFa1aCypxKH+1jIAGZABPjhxfW2
X-Received by 10.66.161.195 with SMTP id xu3mr71257227pab.68.1469819415098; Fri, 29 Jul 2016 12:10:15 -0700 (PDT)
User-Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.2.0
MIME-Version 1.0
Content-Type text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding 7bit
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 49
Organization linux.* mail to news gateway
X-Original-Cc David Miller <davem@davemloft.net>, Mateusz Bajorski <mateusz.bajorski@nokia.com>, lkml <linux-kernel@vger.kernel.org>, Guodong Xu <guodong.xu@linaro.org>, Dmitry Shmidt <dimitrysh@google.com>, Chih-Hung Hsieh <chh@google.com>, Eric Caruso <ejcaruso@google.com>, Lorenzo Colitti <lorenzo@google.com>
X-Original-Date Fri, 29 Jul 2016 13:10:10 -0600
X-Original-Message-ID <54c59314-8f0e-542d-93e6-7953cbcd430e@cumulusnetworks.com>
X-Original-References <CALAqxLUrJ86pJ20ppTycG3e2wv=zegC6UfQdXtnjeQYxQw2iMg@mail.gmail.com> <20160728.212031.549387302791502368.davem@davemloft.net> <5ff19cc3-e607-282d-853a-410b985f8756@cumulusnetworks.com> <CALAqxLWBFyS8VF02tBmAR-Zu1j6Nh7ETZFoWx1fzVgx81rUk1Q@mail.gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1452523

Show key headers only | View raw

On 7/29/16 10:57 AM, John Stultz wrote:
>> I take Android userspace inserts the same rule multiple times? (ip rule ls)
>
> With the patch reverted, and the system working,  I see:
>
> # ip rule ls
> 0:      from all lookup local
> 10000:  from all fwmark 0xc0000/0xd0000 lookup legacy_system
> 13000:  from all fwmark 0x10063/0x1ffff lookup local_network
> 13000:  from all fwmark 0x10065/0x1ffff lookup wlan0
> 14000:  from all oif wlan0 lookup wlan0
> 14000:  from all oif wlan0 lookup wlan0

duplicate rules.

> 15000:  from all fwmark 0x0/0x10000 lookup legacy_system
> 16000:  from all fwmark 0x0/0x10000 lookup legacy_network
> 17000:  from all fwmark 0x0/0x10000 lookup local_network
> 19000:  from all fwmark 0x64/0x1ffff lookup wlan0
> 19000:  from all fwmark 0x65/0x1ffff lookup wlan0
> 22000:  from all fwmark 0x0/0xffff lookup wlan0
> 32000:  from all unreachable
>
> With the patch applied, and after toggling wifi, when I see the problem:
>
> # ip rule ls
> 0:      from all lookup local
> 10000:  from all fwmark 0xc0000/0xd0000 lookup legacy_system
> 13000:  from all fwmark 0x10063/0x1ffff lookup local_network
> 13000:  from all fwmark 0x10065/0x1ffff lookup wlan0
> 14000:  from all oif wlan0 lookup wlan0

The failure would be happening on the insertion of the second wlan0 rule.

> 15000:  from all fwmark 0x0/0x10000 lookup legacy_system
> 16000:  from all fwmark 0x0/0x10000 lookup legacy_network
> 17000:  from all fwmark 0x0/0x10000 lookup local_network
> 19000:  from all fwmark 0x64/0x1ffff lookup wlan0
> 32000:  from all unreachable
>
>
>> If so and multiple components expect to manage their own 'copy' of the rule
>> they will need to remove the NLM_F_EXCL flag.
>
> Adding more networky Android folks to the CC.
>
> thanks
> -john
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule  breaks Android userspace John Stultz <john.stultz@linaro.org> - 2016-07-29 06:20 +0200
  Re: [Regression?] fib_rules: Added NLM_F_EXCL support to  fib_nl_newrule breaks Android userspace David Miller <davem@davemloft.net> - 2016-07-29 06:30 +0200
    Re: [Regression?] fib_rules: Added NLM_F_EXCL support to  fib_nl_newrule breaks Android userspace David Ahern <dsa@cumulusnetworks.com> - 2016-07-29 16:20 +0200
      Re: [Regression?] fib_rules: Added NLM_F_EXCL support to  fib_nl_newrule breaks Android userspace John Stultz <john.stultz@linaro.org> - 2016-07-29 19:00 +0200
        Re: [Regression?] fib_rules: Added NLM_F_EXCL support to  fib_nl_newrule breaks Android userspace David Ahern <dsa@cumulusnetworks.com> - 2016-07-29 21:20 +0200
        Re: [Regression?] fib_rules: Added NLM_F_EXCL support to  fib_nl_newrule breaks Android userspace Lorenzo Colitti <lorenzo@google.com> - 2016-08-01 03:50 +0200
          Re: [Regression?] fib_rules: Added NLM_F_EXCL support to  fib_nl_newrule breaks Android userspace John Stultz <john.stultz@linaro.org> - 2016-08-02 18:40 +0200
            Re: [Regression?] fib_rules: Added NLM_F_EXCL support to  fib_nl_newrule breaks Android userspace David Ahern <dsa@cumulusnetworks.com> - 2016-08-02 19:10 +0200
              Re: [Regression?] fib_rules: Added NLM_F_EXCL support to  fib_nl_newrule breaks Android userspace David Miller <davem@davemloft.net> - 2016-08-02 20:20 +0200
                Re: [Regression?] fib_rules: Added NLM_F_EXCL support to  fib_nl_newrule breaks Android userspace David Miller <davem@davemloft.net> - 2016-08-02 20:30 +0200
                Re: [Regression?] fib_rules: Added NLM_F_EXCL support to  fib_nl_newrule breaks Android userspace John Stultz <john.stultz@linaro.org> - 2016-08-02 20:40 +0200
                Re: [Regression?] fib_rules: Added NLM_F_EXCL support to  fib_nl_newrule breaks Android userspace Lorenzo Colitti <lorenzo@google.com> - 2016-08-03 03:00 +0200
                Re: [Regression?] fib_rules: Added NLM_F_EXCL support to  fib_nl_newrule breaks Android userspace David Miller <davem@davemloft.net> - 2016-08-03 03:20 +0200
              Re: [Regression?] fib_rules: Added NLM_F_EXCL support to  fib_nl_newrule breaks Android userspace John Stultz <john.stultz@linaro.org> - 2016-08-02 21:00 +0200
            Re: [Regression?] fib_rules: Added NLM_F_EXCL support to  fib_nl_newrule breaks Android userspace John Stultz <john.stultz@linaro.org> - 2016-08-02 19:10 +0200

csiph-web