Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1452480

Re: [PATCH] mm: move swap-in anonymous page into active list

From Rik van Riel <riel@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH] mm: move swap-in anonymous page into active list
Date 2016-07-29 19:00 +0200
Message-ID <s0jiF-7fv-1@gated-at.bofh.it> (permalink)
References <s06EO-7sn-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Fri, 2016-07-29 at 12:25 +0900, Minchan Kim wrote:
> Every swap-in anonymous page starts from inactive lru list's head.
> It should be activated unconditionally when VM decide to reclaim
> because page table entry for the page always usually has marked
> accessed bit. Thus, their window size for getting a new referece
> is 2 * NR_inactive + NR_active while others is NR_active + NR_active.
> 
> It's not fair that it has more chance to be referenced compared
> to other newly allocated page which starts from active lru list's
> head.
> 
> Signed-off-by: Minchan Kim <minchan@kernel.org>

Acked-by: Rik van Riel <riel@redhat.com>

The reason newly read in swap cache pages start on the
inactive list is that we do some amount of read-around,
and do not know which pages will get used.

However, immediately activating the ones that DO get
used, like your patch does, is the right thing to do.

-- 
All Rights Reversed.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] mm: move swap-in anonymous page into active list Minchan Kim <minchan@kernel.org> - 2016-07-29 05:30 +0200
  Re: [PATCH] mm: move swap-in anonymous page into active list Johannes Weiner <hannes@cmpxchg.org> - 2016-07-29 15:40 +0200
  Re: [PATCH] mm: move swap-in anonymous page into active list Rik van Riel <riel@redhat.com> - 2016-07-29 19:00 +0200
    Re: [PATCH] mm: move swap-in anonymous page into active list Nadav Amit <nadav.amit@gmail.com> - 2016-07-29 20:10 +0200

csiph-web