Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1452451
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] checkpatch: check signoff when reading stdin |
| Date | 2016-07-29 17:40 +0200 |
| Message-ID | <s0i3g-6ue-7@gated-at.bofh.it> (permalink) |
| References | <rZG7D-62u-29@gated-at.bofh.it> <rZHGq-70S-3@gated-at.bofh.it> <s0hgS-5SV-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 2016-07-29 at 10:45 -0400, Allen Hubbe wrote: > On Wed, Jul 27, 2016 at 8:41 PM, Joe Perches <joe@perches.com> wrote: > > > > I think this is not a great idea because the most likely > > use case is piping git diff output ala: > > > > $ git diff <some_path> | ./scripts/checkpatch.pl - > Thanks for the review. Has v2 addressed your concern? Hi Allen. For the most part, yes, your V2 works better. I was wondering if the - should be optional and thinking $ git diff <some-path> | ./scripts/checkpatch.pl should work the same way, but I guess that can wait for another day, so Acked-by: Joe Perches <joe@perches.com> cheers, Joe
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] checkpatch: check signoff when reading stdin Allen Hubbe <allenbh@gmail.com> - 2016-07-28 01:10 +0200
Re: [PATCH] checkpatch: check signoff when reading stdin Joe Perches <joe@perches.com> - 2016-07-28 02:50 +0200
Re: [PATCH] checkpatch: check signoff when reading stdin Allen Hubbe <allenbh@gmail.com> - 2016-07-29 16:50 +0200
Re: [PATCH] checkpatch: check signoff when reading stdin Joe Perches <joe@perches.com> - 2016-07-29 17:40 +0200
[PATCH v2] checkpatch: check signoff when reading stdin Allen Hubbe <allenbh@gmail.com> - 2016-07-28 04:00 +0200
csiph-web