Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1452410

Re: [PACTH v1 1/2] usb: xhci: plat: Enable runtime PM

Show all headers | View raw

On 2016-07-28 08:24 PM, Felipe Balbi wrote:
>
> Hi,
>
> robert.foss@collabora.com writes:
>> From: Andrew Bresticker <abrestic@chromium.org>
>>
>> Enable runtime PM for the xhci-plat device so that the parent device
>> may implement runtime PM.
>>
>> Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
>> Tested-by: Robert Foss <robert.foss@collabora.com>
>> Signed-off-by: Robert Foss <robert.foss@collabora.com>
>> ---
>>  drivers/usb/host/xhci-plat.c | 19 +++++++++++++++++--
>>  1 file changed, 17 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
>> index ed56bf9..fbd45c2 100644
>> --- a/drivers/usb/host/xhci-plat.c
>> +++ b/drivers/usb/host/xhci-plat.c
>> @@ -246,6 +246,9 @@ static int xhci_plat_probe(struct platform_device *pdev)
>>  	if (ret)
>>  		goto dealloc_usb2_hcd;
>>
>> +	pm_runtime_set_active(&pdev->dev);
>> +	pm_runtime_enable(&pdev->dev);
>> +
>>  	return 0;
>>
>>
>> @@ -274,6 +277,8 @@ static int xhci_plat_remove(struct platform_device *dev)
>>  	struct xhci_hcd	*xhci = hcd_to_xhci(hcd);
>>  	struct clk *clk = xhci->clk;
>>
>> +	pm_runtime_disable(&dev->dev);
>> +
>>  	usb_remove_hcd(xhci->shared_hcd);
>>  	usb_phy_shutdown(hcd->usb_phy);
>>
>> @@ -292,7 +297,9 @@ static int xhci_plat_suspend(struct device *dev)
>>  {
>>  	struct usb_hcd	*hcd = dev_get_drvdata(dev);
>>  	struct xhci_hcd	*xhci = hcd_to_xhci(hcd);
>> +	int ret;
>>
>> +	pm_runtime_get_sync(dev);
>
> you need to check for possible errors here. Ditto to the other occurence
> below.
>

Thanks for the feedback (on this and the 0/2), I'll fix the issues and 
release a v3.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PACTH v1 0/2] usb: xhci: plat: Enable PM, async resume/suspend robert.foss@collabora.com - 2016-07-28 23:20 +0200
  [PACTH v1 1/2] usb: xhci: plat: Enable runtime PM robert.foss@collabora.com - 2016-07-28 23:20 +0200
    Re: [PACTH v1 1/2] usb: xhci: plat: Enable runtime PM Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-07-29 10:30 +0200
      Re: [PACTH v1 1/2] usb: xhci: plat: Enable runtime PM Robert Foss <robert.foss@collabora.com> - 2016-07-29 15:40 +0200
  Re: [PACTH v1 0/2] usb: xhci: plat: Enable PM, async resume/suspend Robert Foss <robert.foss@collabora.com> - 2016-07-28 23:30 +0200
    Re: [PACTH v1 0/2] usb: xhci: plat: Enable PM, async resume/suspend Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-07-29 10:30 +0200

csiph-web