Re: [PATCH 1/3] Add a new field to struct shrinker

From	Mel Gorman <mgorman@techsingularity.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] Add a new field to struct shrinker
Date	2016-07-29 15:10 +0200
Message-ID	<s0fI5-51U-3@gated-at.bofh.it> (permalink)
References	(5 earlier) <rX18B-2KP-19@gated-at.bofh.it> <rZdIl-4pd-23@gated-at.bofh.it> <rZMmJ-1PT-5@gated-at.bofh.it> <rZQJH-4VL-1@gated-at.bofh.it> <s03GV-5iX-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jul 29, 2016 at 10:13:40AM +1000, Dave Chinner wrote:
> On Thu, Jul 28, 2016 at 11:25:13AM +0100, Mel Gorman wrote:
> > On Thu, Jul 28, 2016 at 03:49:47PM +1000, Dave Chinner wrote:
> > > Seems you're all missing the obvious.
> > > 
> > > Add a tracepoint for a shrinker callback that includes a "name"
> > > field, have the shrinker callback fill it out appropriately. e.g
> > > in the superblock shrinker:
> > > 
> > > 	trace_shrinker_callback(shrinker, shrink_control, sb->s_type->name);
> > > 
> > 
> > That misses capturing the latency of the call unless there is a begin/end
> > tracepoint.
> 
> Sure, but I didn't see that in the email talking about how to add a
> name. Even if it is a requirement, it's not necessary as we've
> already got shrinker runtime measurements from the
> trace_mm_shrink_slab_start and trace_mm_shrink_slab_end trace
> points. With the above callback event, shrinker call runtime is
> simply the time between the calls to the same shrinker within
> mm_shrink_slab start/end trace points.
> 

Fair point. It's not that hard to correlate them.

> <SNIP>
> 
> > My understanding was the point of the tracepoints was to get detailed
> > information on points where the kernel is known to stall for long periods
> > of time.
> 
> First I've heard that's what tracepoints are supposed to be used
> for.

I meant the specific case of trace_X_begin followed by trace_X_end, not
tracepoints in general.

-- 
Mel Gorman
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/3] Add a new field to struct shrinker Tony Jones <tonyj@suse.de> - 2016-07-26 18:50 +0200
  Re: [PATCH 1/3] Add a new field to struct shrinker Dave Chinner <david@fromorbit.com> - 2016-07-28 07:50 +0200
    Re: [PATCH 1/3] Add a new field to struct shrinker Mel Gorman <mgorman@techsingularity.net> - 2016-07-28 12:30 +0200
      Re: [PATCH 1/3] Add a new field to struct shrinker Dave Chinner <david@fromorbit.com> - 2016-07-29 02:20 +0200
        Re: [PATCH 1/3] Add a new field to struct shrinker Mel Gorman <mgorman@techsingularity.net> - 2016-07-29 15:10 +0200

csiph-web