Re: [PATCH 4/5] i2c: i801: do not report an error if FEATURE_HOST_NOTIFY is not set

From	Jean Delvare <jdelvare@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/5] i2c: i801: do not report an error if FEATURE_HOST_NOTIFY is not set
Date	2016-07-29 12:50 +0200
Message-ID	<s0dwB-3tH-1@gated-at.bofh.it> (permalink)
References	<rZQgF-4ts-5@gated-at.bofh.it> <rZQgG-4ts-29@gated-at.bofh.it>
Organization	SUSE Linux

Show all headers | View raw

On Thu, 28 Jul 2016 11:50:42 +0200, Benjamin Tissoires wrote:
> we can skip one test when calling i801_enable_host_notify(). Given
> that we call it all the time, it's better to consider the fact that
> the adapter doesn't support Host Notify as not an error.
> 
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> ---
>  drivers/i2c/busses/i2c-i801.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> (...)

Reviewed-by: Jean Delvare <jdelvare@suse.de>

Thanks,
-- 
Jean Delvare
SUSE L3 Support

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] i2c: Host Notify / i801 fixes Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-07-28 12:00 +0200
  [PATCH 5/5] i2c: i801: warn on i2c_handle_smbus_host_notify() errors Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-07-28 12:00 +0200
    Re: [PATCH 5/5] i2c: i801: warn on i2c_handle_smbus_host_notify()  errors Jean Delvare <jdelvare@suse.de> - 2016-08-01 16:40 +0200
  [PATCH 2/5] i2c: i801: minor formatting issues Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-07-28 12:00 +0200
    Re: [PATCH 2/5] i2c: i801: minor formatting issues Jean Delvare <jdelvare@suse.de> - 2016-07-29 11:20 +0200
  [PATCH 1/5] i2c: i2c-smbus: prevent races on remove when Host Notify is used Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-07-28 12:00 +0200
    Re: [PATCH 1/5] i2c: i2c-smbus: prevent races on remove when Host  Notify is used Jean Delvare <jdelvare@suse.de> - 2016-07-29 11:20 +0200
      Re: [PATCH 1/5] i2c: i2c-smbus: prevent races on remove when Host  Notify is used Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-07-29 18:40 +0200
      Re: [PATCH 1/5] i2c: i2c-smbus: prevent races on remove when Host  Notify is used Jean Delvare <jdelvare@suse.de> - 2016-08-01 15:40 +0200
  [PATCH 4/5] i2c: i801: do not report an error if FEATURE_HOST_NOTIFY is not set Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-07-28 12:00 +0200
    Re: [PATCH 4/5] i2c: i801: do not report an error if  FEATURE_HOST_NOTIFY is not set Jean Delvare <jdelvare@suse.de> - 2016-07-29 12:50 +0200

csiph-web