Re: [PATCH 3/5] i2c: i801: use BIT() macro for bits definition

From	Jean Delvare <jdelvare@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/5] i2c: i801: use BIT() macro for bits definition
Date	2016-07-29 11:40 +0200
Message-ID	<s0cqR-2Ol-1@gated-at.bofh.it> (permalink)
References	<rZQgF-4ts-5@gated-at.bofh.it> <rZQgF-4ts-3@gated-at.bofh.it>
Organization	SUSE Linux

Show all headers | View raw

On Thu, 28 Jul 2016 11:50:41 +0200, Benjamin Tissoires wrote:
> i801 mixes hexadecimal and decimal values for defining bits. However,
> we have a nice BIT() macro for this exact purpose.

Looks good to me. But maybe we could convert all the FEATURE_* defines
as well?

> No functional changes, cleanup only.
> 
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> ---
>  drivers/i2c/busses/i2c-i801.c | 50 +++++++++++++++++++++----------------------
>  1 file changed, 25 insertions(+), 25 deletions(-)
> (...)

Reviewed-by: Jean Delvare <jdelvare@suse.de>

-- 
Jean Delvare
SUSE L3 Support

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/5] i2c: i801: use BIT() macro for bits definition Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-07-28 12:00 +0200
  Re: [PATCH 3/5] i2c: i801: use BIT() macro for bits definition Jean Delvare <jdelvare@suse.de> - 2016-07-29 11:40 +0200

csiph-web