Re: [PATCH] s390/pci: Remove unnecessary if condition

From	Sebastian Ott <sebott@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] s390/pci: Remove unnecessary if condition
Date	2016-07-29 10:40 +0200
Message-ID	<s0buO-2d6-19@gated-at.bofh.it> (permalink)
References	<s0buO-2d6-21@gated-at.bofh.it>
Organization	"IBM Deutschland Research & Development GmbH / Vorsitzende des Aufsichtsrats: Martina Koederitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294"

Show all headers | View raw

On Fri, 29 Jul 2016, Amitoj Kaur Chawla wrote:
> Remove unnecessary error handling because the only failure value that
> can be returned is NULL and so the test can never be true.
> 
> The Coccinelle semantic patch used to make this change is as follows:
> @@
> expression e;
> @@
> 
>   e = debugfs_create_file(...);
> - if(IS_ERR(e)) { e = NULL; }

Nope. For !CONFIG_DEBUG_FS debugfs_create_file returns an ERR_PTR.

Regards,
Sebastian

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] s390/pci: Remove unnecessary if condition Sebastian Ott <sebott@linux.vnet.ibm.com> - 2016-07-29 10:40 +0200
  Re: [PATCH] s390/pci: Remove unnecessary if condition Julia Lawall <julia.lawall@lip6.fr> - 2016-07-29 10:50 +0200
    Re: [PATCH] s390/pci: Remove unnecessary if condition Sebastian Ott <sebott@linux.vnet.ibm.com> - 2016-07-29 11:50 +0200
      Re: [PATCH] s390/pci: Remove unnecessary if condition Julia Lawall <julia.lawall@lip6.fr> - 2016-08-01 08:40 +0200

csiph-web