Re: [PATCH 1/1] rtlwifi: remove superfluous condition

From	Larry Finger <Larry.Finger@lwfinger.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] rtlwifi: remove superfluous condition
Date	2016-07-31 16:20 +0200
Message-ID	<s0ZKV-1cv-7@gated-at.bofh.it> (permalink)
References	<s0Wk1-7kp-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 07/31/2016 05:30 AM, Heinrich Schuchardt wrote:
> If sta == NULL, the changed line will not be reached.
> So no need to check if stat == NULL here.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  drivers/net/wireless/realtek/rtlwifi/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I agree. If sta were NULL, we would never have reached this statement. There is, 
however, a typo in the last line of the commit message. Once this is fixed, you 
may add the line "Acked-by: Larry Finger <Larry.Finger@lwfinger.net>"

Thanks,

Larry

>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c b/drivers/net/wireless/realtek/rtlwifi/core.c
> index 41f77f8..7aee5ebb1 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/core.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/core.c
> @@ -1135,7 +1135,7 @@ static void rtl_op_bss_info_changed(struct ieee80211_hw *hw,
>  					mac->mode = WIRELESS_MODE_AC_24G;
>  			}
>
> -			if (vif->type == NL80211_IFTYPE_STATION && sta)
> +			if (vif->type == NL80211_IFTYPE_STATION)
>  				rtlpriv->cfg->ops->update_rate_tbl(hw, sta, 0);
>  			rcu_read_unlock();
>
>

Thread

[PATCH 1/1] rtlwifi: remove superfluous condition Heinrich Schuchardt <xypron.glpk@gmx.de> - 2016-07-31 12:40 +0200
  Re: [PATCH 1/1] rtlwifi: remove superfluous condition Larry Finger <Larry.Finger@lwfinger.net> - 2016-07-31 16:20 +0200
    [PATCH 1/1 v2] rtlwifi: remove superfluous condition Heinrich Schuchardt <xypron.glpk@gmx.de> - 2016-08-02 21:30 +0200
      Re: [PATCH 1/1 v2] rtlwifi: remove superfluous condition Kalle Valo <kvalo@codeaurora.org> - 2016-08-03 12:30 +0200

csiph-web