Re: [PATCH 4/5] s390: Define AT_VECTOR_SIZE_ARCH for ARCH_DLINFO

From	Martin Schwidefsky <schwidefsky@de.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/5] s390: Define AT_VECTOR_SIZE_ARCH for ARCH_DLINFO
Date	2016-07-31 15:30 +0200
Message-ID	<s0YYx-CO-1@gated-at.bofh.it> (permalink)
References	<rYQC5-6GE-3@gated-at.bofh.it> <rYQC5-6GE-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 25 Jul 2016 16:59:53 +0100
James Hogan <james.hogan@imgtec.com> wrote:

> AT_VECTOR_SIZE_ARCH should be defined with the maximum number of
> NEW_AUX_ENT entries that ARCH_DLINFO can contain, but it wasn't defined
> for s390 at all even though ARCH_DLINFO can contain one NEW_AUX_ENT when
> VDSO is enabled.
> 
> This shouldn't be a problem as AT_VECTOR_SIZE_BASE includes space for
> AT_BASE_PLATFORM which s390 doesn't use, but lets define it now and add
> the comment above ARCH_DLINFO as found in several other architectures to
> remind future modifiers of ARCH_DLINFO to keep AT_VECTOR_SIZE_ARCH up to
> date.
> 
> Fixes: b020632e40c3 ("[S390] introduce vdso on s390")
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
> Cc: linux-s390@vger.kernel.org

The patch makes sense. I not quite sure about the checkpoint-restore code
that clears the last two entries of the user_auxv[] without knowing how
many aux entries there really are. That seems kind of strange.

I will the patch to our repositories and we'll give it a spin. If there
is no fallout I queue it to linux-s390.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 4/5] s390: Define AT_VECTOR_SIZE_ARCH for ARCH_DLINFO Martin Schwidefsky <schwidefsky@de.ibm.com> - 2016-07-31 15:30 +0200

csiph-web