Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1452782
| From | Heinrich Schuchardt <xypron.glpk@gmx.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 1/1] dsa: b53: remove redundant if |
| Date | 2016-07-31 09:50 +0200 |
| Message-ID | <s0TFv-5Cn-7@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
For pdata == null the code leaves with an error. There is need to check the condition again. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- drivers/net/dsa/b53/b53_mmap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/dsa/b53/b53_mmap.c b/drivers/net/dsa/b53/b53_mmap.c index 21f1068..77ffc43 100644 --- a/drivers/net/dsa/b53/b53_mmap.c +++ b/drivers/net/dsa/b53/b53_mmap.c @@ -233,8 +233,7 @@ static int b53_mmap_probe(struct platform_device *pdev) if (!dev) return -ENOMEM; - if (pdata) - dev->pdata = pdata; + dev->pdata = pdata; platform_set_drvdata(pdev, dev); -- 2.8.1
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH 1/1] dsa: b53: remove redundant if Heinrich Schuchardt <xypron.glpk@gmx.de> - 2016-07-31 09:50 +0200
Re: [PATCH 1/1] dsa: b53: remove redundant if Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-07-31 12:10 +0200
[PATCH 1/1 v2] dsa: b53: remove redundant if Heinrich Schuchardt <xypron.glpk@gmx.de> - 2016-07-31 13:50 +0200
Re: [PATCH 1/1 v2] dsa: b53: remove redundant if David Miller <davem@davemloft.net> - 2016-08-01 22:50 +0200
csiph-web