Re: [PATCH] random: Fix crashes with sparse node ids

From	Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] random: Fix crashes with sparse node ids
Date	2016-07-31 06:00 +0200
Message-ID	<s0Q4V-3f6-5@gated-at.bofh.it> (permalink)
References	<s0Dr3-3ED-15@gated-at.bofh.it> <s0J3r-7ef-3@gated-at.bofh.it> <s0PBT-31y-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Jul 30, 2016 at 8:27 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> Dropping NOFAIL means we need to handle allocation failures, which makes
> the patch a bit bigger, and less of a pure fix.

Hmm. If you get allocation failures for something like this at init
time, I think you're basically screwed anyway.

And I really only meant for the initial array allocation, and the
__GFP_ZERO thing.

Yes, __GFP_ZERO does work for kmalloc() too, but unlike the other GPF
flags, we do have special zalloc versions for zeroing that are
generally preferred.

              Linus

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] random: Fix crashes with sparse node ids Michael Ellerman <mpe@ellerman.id.au> - 2016-07-30 16:30 +0200
  Re: [PATCH] random: Fix crashes with sparse node ids Linus Torvalds <torvalds@linux-foundation.org> - 2016-07-30 22:30 +0200
    Re: [PATCH] random: Fix crashes with sparse node ids Michael Ellerman <mpe@ellerman.id.au> - 2016-07-31 05:30 +0200
      Re: [PATCH] random: Fix crashes with sparse node ids Linus Torvalds <torvalds@linux-foundation.org> - 2016-07-31 06:00 +0200

csiph-web