Re: [RFC PATCH 4/4] KVM: vmx: add support for emulating UMIP

From	Wanpeng Li <kernellwp@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 4/4] KVM: vmx: add support for emulating UMIP
Date	2016-07-31 04:40 +0200
Message-ID	<s0OPv-2vt-5@gated-at.bofh.it> (permalink)
References	<rUbxw-Oh-21@gated-at.bofh.it> <rUbxw-Oh-27@gated-at.bofh.it> <rUz6N-83G-19@gated-at.bofh.it> <rUK2f-75j-65@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

2016-07-14 16:09 GMT+08:00 Paolo Bonzini <pbonzini@redhat.com>:
[...]
>
> This is not necessary because this is how KVM computes
> CPUID[EAX=7,EBX=0].ECX:
>
>         unsigned f_umip = kvm_x86_ops->umip_emulated() ? F(UMIP) : 0;
>         ...
>         const u32 kvm_cpuid_7_0_ecx_x86_features = F(PKU) | F(UMIP);
>         ...
>         // Mask userspace-provided value against supported features
>         entry->ecx &= kvm_cpuid_7_0_ecx_x86_features;
>         // Mask userspace-provided value against host features
>         cpuid_mask(&entry->ecx, CPUID_7_ECX);
>         // Finally add emulated features
>         entry->ecx |= f_umip;

I think you mean:

- entry->ecx  ->  userspace-provided value
- kvm_cpuid_7_0_ecx_x86_features  ->  supported features
- CPUID_7_ECX  ->  host features

However, entry->ecx is returned by cpuid instruction
(do_cpuid_1_ent()), so why it is a userspace-provided value?

Regards,
Wanpeng Li

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH 4/4] KVM: vmx: add support for emulating UMIP Wanpeng Li <kernellwp@gmail.com> - 2016-07-31 04:40 +0200
  Re: [RFC PATCH 4/4] KVM: vmx: add support for emulating UMIP Paolo Bonzini <pbonzini@redhat.com> - 2016-08-01 17:10 +0200
    Re: [RFC PATCH 4/4] KVM: vmx: add support for emulating UMIP Wanpeng Li <kernellwp@gmail.com> - 2016-08-02 09:00 +0200

csiph-web