Re: [PATCH] sched/core: add taint on "BUG: sleeping function called from invalid context"

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Vegard Nossum <vegard.nossum@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] sched/core: add taint on "BUG: sleeping function called from invalid context"
Date	Fri, 29 Jul 2016 08:40:01 +0200
Message-ID	<s09CF-Yc-5@gated-at.bofh.it> (permalink)
References	<rXOCm-1EM-11@gated-at.bofh.it> <s04MG-63R-17@gated-at.bofh.it>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding	7bit
X-Source-IP	userv0021.oracle.com [156.151.31.71]
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	32
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@kernel.org>
X-Original-Date	Fri, 29 Jul 2016 08:29:22 +0200
X-Original-Message-ID	<579AF7C2.9020009@oracle.com>
X-Original-References	<1469216762-19626-1-git-send-email-vegard.nossum@oracle.com> <8737mtz1a6.fsf@rustcorp.com.au>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1452271

Show key headers only | View raw

On 07/29/2016 03:22 AM, Rusty Russell wrote:
> Vegard Nossum <vegard.nossum@oracle.com> writes:
>> Seeing this, it occurs to me that we should probably add a taint here:
>
> Taint has traditionally meant "the user did something unsupported, take
> the bug report with a grain of salt".  Such as force removing a module.
>
> So this seems wrong...

There are many types of taints. This is the one you mentioned:

    2 - A module was force loaded by insmod -f.

This is the one I'd like to set:

  512 - A kernel warning has occurred.

(from Documentation/sysctl/kernel.txt).

The flag I want to set is also set on any kind of WARN().

>>      BUG: sleeping function called from invalid context at mm/slab.h:388
>>      in_atomic(): 0, irqs_disabled(): 0, pid: 32211, name: trinity-c3
>>      Preemption disabled at:[<ffffffff811aaa37>] console_unlock+0x2f7/0x930

I am not proposing this patch on a whim: it was actually hiding real
bugs because I only saw an oops that happened later when in fact the
real bug happened where the "sleeping function called from invalid
context" was called.

Vegard

Thread

Re: [PATCH] sched/core: add taint on "BUG: sleeping function called from invalid context" Rusty Russell <rusty@rustcorp.com.au> - 2016-07-29 03:30 +0200
  Re: [PATCH] sched/core: add taint on "BUG: sleeping function called  from invalid context" Vegard Nossum <vegard.nossum@oracle.com> - 2016-07-29 08:40 +0200
  Re: [PATCH] sched/core: add taint on "BUG: sleeping function called  from invalid context" Thomas Gleixner <tglx@linutronix.de> - 2016-07-29 15:10 +0200

csiph-web