Re: [PATCH v3 2/2] tpm: add driver for cr50 on SPI

From	Andrey Pronin <apronin@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/2] tpm: add driver for cr50 on SPI
Date	2016-07-29 05:10 +0200
Message-ID	<s06lr-7k3-3@gated-at.bofh.it> (permalink)
References	<rV133-14j-7@gated-at.bofh.it> <rZL7k-14A-21@gated-at.bofh.it> <s02Bc-4AR-21@gated-at.bofh.it> <s02KR-4FC-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jul 28, 2016 at 05:17:06PM -0600, Jason Gunthorpe wrote:
> On Thu, Jul 28, 2016 at 04:01:41PM -0700, Dmitry Torokhov wrote:
> 
> > > +	u8 tx_buf[MAX_SPI_FRAMESIZE];
> > > +	u8 rx_buf[MAX_SPI_FRAMESIZE];
> > 
> > Both of these need to be annotated as "____cacheline_aligned" since we
> > eye them for use in DMA transfers.
> 
> Huh. That sure looks true to me..
> 
> We make that same mistake in all other tpm SPI drivers.
> 
> Can someone send a patch please?
> 

Just did.

Thanks,
Andrey

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/2] tpm: add driver for cr50 on SPI Andrey Pronin <apronin@chromium.org> - 2016-07-28 06:30 +0200
  [PATCH v3 2/2] tpm: add driver for cr50 on SPI Andrey Pronin <apronin@chromium.org> - 2016-07-28 06:30 +0200
    Re: [PATCH v3 2/2] tpm: add driver for cr50 on SPI Dmitry Torokhov <dtor@chromium.org> - 2016-07-29 01:10 +0200
      Re: [PATCH v3 2/2] tpm: add driver for cr50 on SPI Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-07-29 01:20 +0200
        Re: [PATCH v3 2/2] tpm: add driver for cr50 on SPI Andrey Pronin <apronin@chromium.org> - 2016-07-29 05:10 +0200

csiph-web