Re: [PATCH v11] acpi, apei, arm64: APEI initial support for aarch64.

From	Fu Wei <fu.wei@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v11] acpi, apei, arm64: APEI initial support for aarch64.
Date	2016-07-29 04:30 +0200
Message-ID	<s05IJ-6MV-1@gated-at.bofh.it> (permalink)
References	<rZAOC-2kF-15@gated-at.bofh.it> <rZQ6Z-4pS-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Suzuki,

On 28 July 2016 at 17:39, Suzuki K Poulose <Suzuki.Poulose@arm.com> wrote:
> On 27/07/16 18:29, fu.wei@linaro.org wrote:
>>
>> From: Tomasz Nowicki <tomasz.nowicki@linaro.org>
>>
>> This commit provides APEI arch-specific bits for aarch64
>>
>> Meanwhile,
>> (1)add a new subfunction "hest_ia32_init" for
>> "acpi_disable_cmcff" which is used by IA-32 Architecture
>> Corrected Machine Check (CMC).
>> (2)move HEST type (ACPI_HEST_TYPE_IA32_CORRECTED_CHECK) checking to
>> a generic place.
>> (3)select HAVE_ACPI_APEI when EFI and ACPI is set on ARM64,
>> because arch_apei_get_mem_attribute is using efi_mem_attributes on ARM64.
>>
>> [Fu Wei: improve && upstream]
>>
>
>
>> diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h
>> index 5420cb0..d3d02dc 100644
>> --- a/arch/arm64/include/asm/acpi.h
>> +++ b/arch/arm64/include/asm/acpi.h
>> @@ -17,6 +17,7 @@
>>
>>  #include <asm/cputype.h>
>>  #include <asm/smp_plat.h>
>> +#include <asm/tlbflush.h>
>>
>>  /* Macros for consistency checks of the GICC subtable of MADT */
>>  #define ACPI_MADT_GICC_LENGTH  \
>> @@ -110,8 +111,21 @@ static inline const char *acpi_get_enable_method(int
>> cpu)
>>  }
>>
>>  #ifdef CONFIG_ACPI_APEI
>> +#define acpi_disable_cmcff 1
>>  pgprot_t arch_apei_get_mem_attribute(phys_addr_t addr);
>> -#endif
>> +
>> +/*
>> + * Despite its name, this function must still broadcast the TLB
>> + * invalidation in order to ensure other CPUs don't up with with junk
>
>
> Please fix the comment above ^^^.

Thanks for pointing it out, the fixed patch will out in minutes.

>
>
> Suzuki



-- 
Best regards,

Fu Wei
Software Engineer
Red Hat

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v11] acpi, apei, arm64: APEI initial support for aarch64. fu.wei@linaro.org - 2016-07-27 19:30 +0200
  Re: [PATCH v11] acpi, apei, arm64: APEI initial support for aarch64. "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-07-28 01:10 +0200
    Re: [PATCH v11] acpi, apei, arm64: APEI initial support for aarch64. Fu Wei <fu.wei@linaro.org> - 2016-07-28 05:40 +0200
  Re: [PATCH v11] acpi, apei, arm64: APEI initial support for aarch64. Suzuki K Poulose <Suzuki.Poulose@arm.com> - 2016-07-28 11:50 +0200
    Re: [PATCH v11] acpi, apei, arm64: APEI initial support for aarch64. Fu Wei <fu.wei@linaro.org> - 2016-07-29 04:30 +0200

csiph-web