Re: [PATCH v4 2/2] input: add ADC resistor ladder driver

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 2/2] input: add ADC resistor ladder driver
Date	2016-07-29 00:50 +0200
Message-ID	<s02hQ-4cF-5@gated-at.bofh.it> (permalink)
References	<rUbHb-S4-9@gated-at.bofh.it> <rUbHc-S4-23@gated-at.bofh.it> <rUgxb-3YH-1@gated-at.bofh.it> <s01F7-3X8-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 28/07/2016 at 15:09:18 -0700, Dmitry Torokhov wrote :
> On Tue, Jul 12, 2016 at 05:41:50PM -0700, Dmitry Torokhov wrote:
> > Hi Alexandre,
> > 
> > On Tue, Jul 12, 2016 at 09:36:26PM +0200, Alexandre Belloni wrote:
> > > A common way of multiplexing buttons on a single input in cheap devices is
> > > to use a resistor ladder on an ADC. This driver supports that configuration
> > > by polling an ADC channel provided by IIO.
> > 
> > This looks quite reasonable, just a few small comments.
> 
> Ping.
> 
> Did the version below work for you? I am trying sweep in the brand new
> drivers before we close merge window.
> 

I was thinking it was too late for 4.8. I've juste tested and it works
fine. However, I just sent v5 including the exact same changes but
changing mvolt to millivolt as that seemed preferred by Rob. Both
versions haver been tested and are fine for me.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Thread

Re: [PATCH v4 2/2] input: add ADC resistor ladder driver Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-07-29 00:10 +0200
  Re: [PATCH v4 2/2] input: add ADC resistor ladder driver Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-07-29 00:50 +0200
    Re: [PATCH v4 2/2] input: add ADC resistor ladder driver Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-07-29 01:50 +0200

csiph-web