Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1452138

Re: [PATCH 2/2] thermal: rockchip: optimize sensor auto accessing period

Path csiph.com!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From Stephen Barber <smbarber@chromium.org>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] thermal: rockchip: optimize sensor auto accessing period
Date Fri, 29 Jul 2016 00:00:02 +0200
Message-ID <s01vs-3Eo-9@gated-at.bofh.it> (permalink)
References <rZxQJ-ug-9@gated-at.bofh.it> <rZxQJ-ug-7@gated-at.bofh.it>
X-Original-To Caesar Wang <wxt@rock-chips.com>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=eyzmObY876HEMDT0TBaBAa0HsxuTC6B/MiMjZYu0o6k=; b=Y6Ll33+X3Txeur6KuJS4t4uR13L7+l7L2n0kZkkKAtzK6YygT3/MtfF8QzaxgYAwCH mDzwa/7i6acO4GEu4ucJXTmGb4Paa8cCrSGGdAhR2xREX7ikXHc9w/aQ371Z5U8X2Lff Bort7AsAN2/KxXDtmeO5r/NyAeoYsSxxdhYnICQIa7Jb1kHTRh6i9ON8dMpIKH+6R/DL obrIY3AueIYqQ886g/nY1POQx4oBZUYrJvWdNBZgf1H/XZLCwlNJOySi04VjT5RlW+rh BO5q8hVrjtFSxYh0WOOE/gGL1RXS6kiaXBCxULFYPDh30rTcKzuKGuYe2RWk25av5SRC BO8A==
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=eyzmObY876HEMDT0TBaBAa0HsxuTC6B/MiMjZYu0o6k=; b=A5GUvUbOtOCuyOexReD6Z1QdDSYDqsJkA9rneTs731Rvg1k/Zvb1SoMEtWgIMJXMsT ZRHLCPtAxvYoUgXq0zzWrJf3Gu/2Mr7lB/Eoq0zIRPNUPgg3JRXl3tEnLD79NT0a5hXd elO1024Q0LaRQyfU5+cx8ubH9QPNBlpaEmuWc=
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=eyzmObY876HEMDT0TBaBAa0HsxuTC6B/MiMjZYu0o6k=; b=OD34UNDeohStc5q9gHOMjx9cYLmrkEk5xlLsY1oEbHlkyey1GIhBgeNyylsn3JJgcC LxHSmBtlkKABQRo5rEhc13lZn0ERkfZoCXqHrFKYf9mkwG725d+xxQgjd4eMyXXllyoP YiTcaJVSd2zyYQltZVas9AZye9eHeYQYm3Pe0PpKN0wA0D8W1JakzVnA47PNRAujB9NA RLZLJAMHulzfOStw2X4YYd/ehjyf4n5Owq05g6idokMqEqLc5Uv1oWPYLiq6oXnkllUK T6tHxc2P42/ZxxwNhzCoBjvwbjyceYBht24YaYHAOzK24iIYMPdrTdFDk07SpT2lTTMD 6Klw==
X-Gm-Message-State AEkoousmouFpjijMn8U8CPG2FhwELAsXrZtA3UDnH99ZGG1lnO6D3W88H+iwOz0z7N/CHkSWU+tBfVtOpSGmUCd0
X-Received by 10.36.184.65 with SMTP id m62mr27421576ite.55.1469742827464; Thu, 28 Jul 2016 14:53:47 -0700 (PDT)
MIME-Version 1.0
X-Google-Sender-Auth aqT2zDM3xkDQdzW2nzFA9nu4zrA
Content-Type text/plain; charset=UTF-8
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 44
Organization linux.* mail to news gateway
X-Original-Cc Eduardo Valentin <edubezval@gmail.com>, Douglas Anderson <dianders@chromium.org>, Brian Norris <briannorris@chromium.org>, Rocky Hao <rocky.hao@rock-chips.com>, Zhang Rui <rui.zhang@intel.com>, Heiko Stuebner <heiko@sntech.de>, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
X-Original-Date Thu, 28 Jul 2016 14:53:28 -0700
X-Original-Message-ID <CADR9n4__hcQosSOM5w0PMw8ck_gPi4Sc5ixbN6CiKKGia2gd7A@mail.gmail.com>
X-Original-References <1469628643-29661-1-git-send-email-wxt@rock-chips.com> <1469628643-29661-2-git-send-email-wxt@rock-chips.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1452138

Show key headers only | View raw


On Wed, Jul 27, 2016 at 7:10 AM, Caesar Wang <wxt@rock-chips.com> wrote:
> From: Rocky Hao <rocky.hao@rock-chips.com>
>
> In less than 10 ms, the temperature of soc will arise 10 degree. 250 ms
> is too big for soc tempeture control. Setting 2.5 ms will speed up
> temperature accessing speed but introduce no more cpu's computing overhead.
> We set AUTO_PERIOD_TIME and TSADCV3_AUTO_PERIOD_HT_TIME the same value,
> because normal temperature update speed is also our consern in IPA.
>
> Signed-off-by: Rocky Hao <rocky.hao@rock-chips.com>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Eduardo Valentin <edubezval@gmail.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: linux-pm@vger.kernel.org
>
> ---
>
>  drivers/thermal/rockchip_thermal.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c
> index a90423d..1f165c9 100644
> --- a/drivers/thermal/rockchip_thermal.c
> +++ b/drivers/thermal/rockchip_thermal.c
> @@ -213,8 +213,8 @@ struct rockchip_thermal_data {
>  #define TSADCV2_HIGHT_TSHUT_DEBOUNCE_COUNT     4
>  #define TSADCV2_AUTO_PERIOD_TIME               250 /* 250ms */
>  #define TSADCV2_AUTO_PERIOD_HT_TIME            50  /* 50ms */
> -#define TSADCV3_AUTO_PERIOD_TIME               187500 /* 250ms */
> -#define TSADCV3_AUTO_PERIOD_HT_TIME            37500  /* 50ms */
> +#define TSADCV3_AUTO_PERIOD_TIME               1875 /* 2.5ms */
> +#define TSADCV3_AUTO_PERIOD_HT_TIME            1875 /* 2.5ms */
>
>  #define TSADCV2_USER_INTER_PD_SOC              0x340 /* 13 clocks */
>
> --
> 1.9.1
>


Tested-by: Stephen Barber <smbarber@chromium.org>

Steve

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH 2/2] thermal: rockchip: optimize sensor auto accessing period Caesar Wang <wxt@rock-chips.com> - 2016-07-27 16:20 +0200
  Re: [PATCH 2/2] thermal: rockchip: optimize sensor auto accessing period Stephen Barber <smbarber@chromium.org> - 2016-07-29 00:00 +0200

csiph-web