Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1452148

Re: [PATCH net 1/3] r8169:fix kernel log spam when set or get hardware wol setting.

From Francois Romieu <romieu@fr.zoreil.com>
Newsgroups linux.kernel
Subject Re: [PATCH net 1/3] r8169:fix kernel log spam when set or get hardware wol setting.
Date 2016-07-29 00:20 +0200
Message-ID <s01ON-40K-7@gated-at.bofh.it> (permalink)
References <rZAlz-1Uf-3@gated-at.bofh.it> <rZAlz-1Uf-1@gated-at.bofh.it> <rZFlf-5mX-3@gated-at.bofh.it> <rZT4R-6ny-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hau <hau@realtek.com> :
[...]
> > Either the driver resumes the device so that it can perform requested
> > operation or it signals .set_wol failure when the device is suspended.
> > 
> > If the driver does something else, "spam removal" translates to "silent
> > failure".
> 
> Because "tp->saved_wolopts" will be used to set hardware wol capability in
> rtl8169_runtime_resume().  So I prefer to keep "wol->wolopts" to
> " tp->saved_wolopts " in runtime suspend state and set this to this
> "wol->wolopts" to hardware in in rtl8169_runtime_resume(). 

It would be fine if it could be proven that rtl8169_runtime_resume() will
always be run before software state is lost.

-- 
Ueimor

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net 1/3] r8169:fix kernel log spam when set or get hardware wol setting. Chunhao Lin <hau@realtek.com> - 2016-07-27 19:00 +0200
  Re: [PATCH net 1/3] r8169:fix kernel log spam when set or get  hardware wol setting. Francois Romieu <romieu@fr.zoreil.com> - 2016-07-28 00:20 +0200
    RE: [PATCH net 1/3] r8169:fix kernel log spam when set or get hardware wol setting. Hau <hau@realtek.com> - 2016-07-28 15:00 +0200
      Re: [PATCH net 1/3] r8169:fix kernel log spam when set or get  hardware wol setting. Francois Romieu <romieu@fr.zoreil.com> - 2016-07-29 00:20 +0200
  Re: [PATCH net 1/3] r8169:fix kernel log spam when set or get  hardware wol setting. Francois Romieu <romieu@fr.zoreil.com> - 2016-07-28 00:20 +0200
    RE: [PATCH net 1/3] r8169:fix kernel log spam when set or get hardware wol setting. Hau <hau@realtek.com> - 2016-07-28 15:10 +0200

csiph-web