Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1452113

Re: [PATCH] Kbuild: Move -Wmaybe-uninitialized to W=1

From Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH] Kbuild: Move -Wmaybe-uninitialized to W=1
Date 2016-07-28 23:30 +0200
Message-ID <s012p-3rN-7@gated-at.bofh.it> (permalink)
References (2 earlier) <nwGBA-4bA-25@gated-at.bofh.it> <nBeOl-7wr-1@gated-at.bofh.it> <rZL7k-14A-23@gated-at.bofh.it> <rZORz-3Ef-9@gated-at.bofh.it> <rZYQV-20O-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Jul 28, 2016 at 12:03 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> And the new warnings were actually not so much due to new code in 4.7,
> as the fact that in between I did a user-space upgrade, and gcc 6.1.1
> has regressed to the point of the warnings being an unusable mess.

Actually, thinking more about this, I'm not convinced it's a gcc
regression, because older gcc's have defainitely had the same problem
with that warning causing tons of spurious issues.

So it might actually mostly be due commit 877417e6ffb9 ("Kbuild:
change CC_OPTIMIZE_FOR_SIZE definition"). As a result of that, we now
end up not using CC_OPTIMIZE_FOR_SIZE for allmodconfig builds.

And since for us, -Os always disabled that warning anyway (because gcc
has always made a bad job of it), the bogus warnings didn't use to be
so annoying and hide the real things.

Of course, a big part of the reasoning for that commit was apparently
because Arnd liked the warning. It back-fired. Now that warning is
gone for everybody, because it's so broken.

                   Linus

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] Kbuild: Move -Wmaybe-uninitialized to W=1 Borislav Petkov <bp@alien8.de> - 2016-07-28 06:30 +0200
  Re: [PATCH] Kbuild: Move -Wmaybe-uninitialized to W=1 Ingo Molnar <mingo@kernel.org> - 2016-07-28 10:30 +0200
    Re: [PATCH] Kbuild: Move -Wmaybe-uninitialized to W=1 Borislav Petkov <bp@alien8.de> - 2016-07-28 10:50 +0200
      Re: [PATCH] Kbuild: Move -Wmaybe-uninitialized to W=1 Ingo Molnar <mingo@kernel.org> - 2016-07-28 19:00 +0200
        Re: [PATCH] Kbuild: Move -Wmaybe-uninitialized to W=1 Ingo Molnar <mingo@kernel.org> - 2016-07-28 19:10 +0200
      Re: [PATCH] Kbuild: Move -Wmaybe-uninitialized to W=1 Markus Trippelsdorf <markus@trippelsdorf.de> - 2016-07-28 20:10 +0200
    Re: [PATCH] Kbuild: Move -Wmaybe-uninitialized to W=1 Linus Torvalds <torvalds@linux-foundation.org> - 2016-07-28 21:10 +0200
      Re: [PATCH] Kbuild: Move -Wmaybe-uninitialized to W=1 Linus Torvalds <torvalds@linux-foundation.org> - 2016-07-28 21:10 +0200
        Re: [PATCH] Kbuild: Move -Wmaybe-uninitialized to W=1 Ingo Molnar <mingo@kernel.org> - 2016-07-28 22:30 +0200
      Re: [PATCH] Kbuild: Move -Wmaybe-uninitialized to W=1 Linus Torvalds <torvalds@linux-foundation.org> - 2016-07-28 23:30 +0200
        Re: [PATCH] Kbuild: Move -Wmaybe-uninitialized to W=1 Borislav Petkov <bp@alien8.de> - 2016-07-29 12:20 +0200
          Re: [PATCH] Kbuild: Move -Wmaybe-uninitialized to W=1 Arnd Bergmann <arnd@arndb.de> - 2016-07-29 12:40 +0200
          Re: [PATCH] Kbuild: Move -Wmaybe-uninitialized to W=1 Linus Torvalds <torvalds@linux-foundation.org> - 2016-07-29 20:30 +0200
        Re: [PATCH] Kbuild: Move -Wmaybe-uninitialized to W=1 Arnd Bergmann <arnd@arndb.de> - 2016-07-29 12:20 +0200

csiph-web