Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1401789

[PATCH 1/5] f2fs: manipulate dirty file inodes when DATA_FLUSH is set

Show all headers | View raw

It needs to maintain dirty file inodes only if DATA_FLUSH is set.
Otherwise, let's avoid its overhead.

Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
 fs/f2fs/checkpoint.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
index 3da6499..d04113b 100644
--- a/fs/f2fs/checkpoint.c
+++ b/fs/f2fs/checkpoint.c
@@ -785,9 +785,11 @@ void update_dirty_page(struct inode *inode, struct page *page)
 			!S_ISLNK(inode->i_mode))
 		return;
 
-	spin_lock(&sbi->inode_lock[type]);
-	__add_dirty_inode(inode, type);
-	spin_unlock(&sbi->inode_lock[type]);
+	if (type != FILE_INODE || test_opt(sbi, DATA_FLUSH)) {
+		spin_lock(&sbi->inode_lock[type]);
+		__add_dirty_inode(inode, type);
+		spin_unlock(&sbi->inode_lock[type]);
+	}
 
 	inode_inc_dirty_pages(inode);
 	SetPagePrivate(page);
@@ -803,6 +805,9 @@ void remove_dirty_inode(struct inode *inode)
 			!S_ISLNK(inode->i_mode))
 		return;
 
+	if (type == FILE_INODE && !test_opt(sbi, DATA_FLUSH))
+		return;
+
 	spin_lock(&sbi->inode_lock[type]);
 	__remove_dirty_inode(inode, type);
 	spin_unlock(&sbi->inode_lock[type]);
-- 
2.6.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/5] f2fs: manipulate dirty file inodes when DATA_FLUSH is set Jaegeuk Kim <jaegeuk@kernel.org> - 2016-05-17 00:40 +0200
  [PATCH 3/5] f2fs: use percpu_counter for # of dirty pages in inode Jaegeuk Kim <jaegeuk@kernel.org> - 2016-05-17 00:40 +0200
  [PATCH 2/5] f2fs: use percpu_counter for page counters Jaegeuk Kim <jaegeuk@kernel.org> - 2016-05-17 00:40 +0200
  [PATCH 4/5] f2fs: use percpu_counter for alloc_valid_block_count Jaegeuk Kim <jaegeuk@kernel.org> - 2016-05-17 00:40 +0200
  [PATCH 5/5] f2fs: use percpu_counter for total_valid_inode_count Jaegeuk Kim <jaegeuk@kernel.org> - 2016-05-17 00:40 +0200

csiph-web