Re: [PATCH] Use MICRO UINT_MAX instead of actual value

From	"Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Use MICRO UINT_MAX instead of actual value
Date	2016-05-17 00:40 +0200
Message-ID	<rzzl7-4AJ-13@gated-at.bofh.it> (permalink)
References	<rrFe1-7fN-1@gated-at.bofh.it> <rtAae-66I-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 04/30/2016 07:13 AM, Minfei Huang wrote:
> Ping.
>
> Any comment is appreciate.

Hi Minfei, I guess a good idea would be to resend the patch with the 
typo fixed, as a v2 patch. What do you think?

Cheers,


Guilherme

>
> Thanks
> Minfei
>
> On 04/25/16 at 11:13P, Minfei Huang wrote:
>> It's more elegant to use MICRO UINT_MAX to represent the max value of
>> type unsigned int. So replace the actual value by using this MICRO.
>>
>> Signed-off-by: Minfei Huang <mnghuan@gmail.com>
>> ---
>>   drivers/nvme/host/core.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
>> index 643f457..2c0bb13 100644
>> --- a/drivers/nvme/host/core.c
>> +++ b/drivers/nvme/host/core.c
>> @@ -597,7 +597,7 @@ static void nvme_config_discard(struct nvme_ns *ns)
>>
>>   	ns->queue->limits.discard_alignment = logical_block_size;
>>   	ns->queue->limits.discard_granularity = logical_block_size;
>> -	blk_queue_max_discard_sectors(ns->queue, 0xffffffff);
>> +	blk_queue_max_discard_sectors(ns->queue, UINT_MAX);
>>   	queue_flag_set_unlocked(QUEUE_FLAG_DISCARD, ns->queue);
>>   }
>>
>> --
>> 2.6.3
>>
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] Use MICRO UINT_MAX instead of actual value "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com> - 2016-05-17 00:40 +0200

csiph-web