[PATCH 1/2] video: fbdev: pmag-ba-fb: Remove bad `__init' annotation

From	"Maciej W. Rozycki" <macro@linux-mips.org>
Newsgroups	linux.kernel
Subject	[PATCH 1/2] video: fbdev: pmag-ba-fb: Remove bad `__init' annotation
Date	2016-05-17 01:10 +0200
Message-ID	<rzzO9-4Zs-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Fix:

WARNING: drivers/video/fbdev/pmag-ba-fb.o(.text+0x308): Section mismatch in reference from the function pmagbafb_probe() to the function .init.text:pmagbafb_erase_cursor()
The function pmagbafb_probe() 
references the function __init pmagbafb_erase_cursor().
This is often because pmagbafb_probe lacks a __init
annotation or the annotation of pmagbafb_erase_cursor is wrong.

-- a fallout from a missed update from commit 9625b51350cc ("VIDEO: 
PMAG-BA: Fix section mismatch") and then commit 48c68c4f1b54 ("Drivers: 
video: remove __dev* attributes.")

Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
---
linux-pmag-ba-init.diff
Index: linux-20160515-declance-module/drivers/video/fbdev/pmag-ba-fb.c
===================================================================
--- linux-20160515-declance-module.orig/drivers/video/fbdev/pmag-ba-fb.c
+++ linux-20160515-declance-module/drivers/video/fbdev/pmag-ba-fb.c
@@ -129,7 +129,7 @@ static struct fb_ops pmagbafb_ops = {
 /*
  * Turn the hardware cursor off.
  */
-static void __init pmagbafb_erase_cursor(struct fb_info *info)
+static void pmagbafb_erase_cursor(struct fb_info *info)
 {
 	struct pmagbafb_par *par = info->par;

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 1/2] video: fbdev: pmag-ba-fb: Remove bad `__init'  annotation "Maciej W. Rozycki" <macro@linux-mips.org> - 2016-05-17 01:10 +0200

csiph-web