Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1401716
| From | Borislav Petkov <bp@suse.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] ftrace/x86: Fix function graph tracer reset path |
| Date | 2016-05-16 21:20 +0200 |
| Message-ID | <rzwdz-2AX-7@gated-at.bofh.it> (permalink) |
| References | (4 earlier) <rzpYt-74T-3@gated-at.bofh.it> <rzrdT-7Kg-17@gated-at.bofh.it> <rzrGX-892-31@gated-at.bofh.it> <rzw3U-2xP-21@gated-at.bofh.it> <rzwdz-2AX-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, May 16, 2016 at 03:13:57PM -0400, Steven Rostedt wrote:
> I actually thought about this first, but I thought it rather a hack
> (although one could argue all of function tracing is a hack ;-)
... I was about to say...
> But as the "weak" call was used to fix one location, why not use
> it here too. Being consistent, and also making sure all calls to
> ftrace_stub do the same.
Btw, arch_static_branch_jump() spells that 5-byte JMP too and not until
too long ago we had it in static_cpu_has()...
I guess after spending some time with the kernel, one can't really
differentiate hacks from proper design anymore. :-P
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] ftrace/x86: Fix function graph tracer reset path Namhyung Kim <namhyung@kernel.org> - 2016-05-13 16:00 +0200
Re: [PATCH] ftrace/x86: Fix function graph tracer reset path Steven Rostedt <rostedt@goodmis.org> - 2016-05-13 16:10 +0200
Re: [PATCH] ftrace/x86: Fix function graph tracer reset path Matt Fleming <matt@codeblueprint.co.uk> - 2016-05-16 04:10 +0200
Re: [PATCH] ftrace/x86: Fix function graph tracer reset path Namhyung Kim <namhyung@kernel.org> - 2016-05-16 04:10 +0200
Re: [PATCH] ftrace/x86: Fix function graph tracer reset path Namhyung Kim <namhyung@kernel.org> - 2016-05-16 14:40 +0200
Re: [PATCH] ftrace/x86: Fix function graph tracer reset path Steven Rostedt <rostedt@goodmis.org> - 2016-05-16 16:00 +0200
Re: [PATCH] ftrace/x86: Fix function graph tracer reset path Namhyung Kim <namhyung@kernel.org> - 2016-05-16 16:30 +0200
Re: [PATCH] ftrace/x86: Fix function graph tracer reset path Borislav Petkov <bp@suse.de> - 2016-05-16 21:10 +0200
Re: [PATCH] ftrace/x86: Fix function graph tracer reset path Borislav Petkov <bp@suse.de> - 2016-05-16 21:20 +0200
Re: [PATCH] ftrace/x86: Fix function graph tracer reset path Steven Rostedt <rostedt@goodmis.org> - 2016-05-16 21:30 +0200
Re: [PATCH] ftrace/x86: Fix function graph tracer reset path Steven Rostedt <rostedt@goodmis.org> - 2016-05-16 21:20 +0200
Re: [PATCH] ftrace/x86: Fix function graph tracer reset path Matt Fleming <matt@codeblueprint.co.uk> - 2016-05-16 22:00 +0200
Re: [PATCH] ftrace/x86: Fix function graph tracer reset path Masami Hiramatsu <mhiramat@kernel.org> - 2016-05-17 00:10 +0200
Re: [PATCH] ftrace/x86: Fix function graph tracer reset path Masami Hiramatsu <mhiramat@kernel.org> - 2016-05-16 04:10 +0200
csiph-web