Re: [PATCHv8 resend 2/2] selftest/x86: add mremap vdso test

From	Andy Lutomirski <luto@amacapital.net>
Newsgroups	linux.kernel
Subject	Re: [PATCHv8 resend 2/2] selftest/x86: add mremap vdso test
Date	2016-05-16 20:30 +0200
Message-ID	<rzvrh-25A-17@gated-at.bofh.it> (permalink)
References	<rxgcV-3iL-9@gated-at.bofh.it> <rxgcW-3iL-11@gated-at.bofh.it> <rzrdU-7Kg-29@gated-at.bofh.it> <rztSq-10v-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, May 16, 2016 at 9:24 AM, Dmitry Safonov <dsafonov@virtuozzo.com> wrote:
> On 05/16/2016 04:54 PM, Ingo Molnar wrote:
>>
>>
>> * Dmitry Safonov <dsafonov@virtuozzo.com> wrote:
>>
>>> Should print on success:
>>> [root@localhost ~]# ./test_mremap_vdso_32
>>>         AT_SYSINFO_EHDR is 0xf773f000
>>> [NOTE]  Moving vDSO: [f773f000, f7740000] -> [a000000, a001000]
>>> [OK]
>>> Or segfault if landing was bad (before patches):
>>> [root@localhost ~]# ./test_mremap_vdso_32
>>>         AT_SYSINFO_EHDR is 0xf774f000
>>> [NOTE]  Moving vDSO: [f774f000, f7750000] -> [a000000, a001000]
>>> Segmentation fault (core dumped)
>>
>>
>> Can the segfault be caught and recovered from, to print a proper failure
>> message?
>
>
> Will add segfault handler, thanks.
>

It may be more complicated that that.  Glibc is likely to explode if
this happens, and the headers are sufficiently screwed up that it's
awkward to bypass glibc and call rt_sigaction directly.  I have a test
that does the latter, though, so it's at least possible, but I'm
unconvinced it's worth it just for an error message.

-- 
Andy Lutomirski
AMA Capital Management, LLC

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCHv8 resend 2/2] selftest/x86: add mremap vdso test Ingo Molnar <mingo@kernel.org> - 2016-05-16 16:00 +0200
  Re: [PATCHv8 resend 2/2] selftest/x86: add mremap vdso test Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-05-16 18:50 +0200
    Re: [PATCHv8 resend 2/2] selftest/x86: add mremap vdso test Andy Lutomirski <luto@amacapital.net> - 2016-05-16 20:30 +0200

csiph-web