Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1401707

Re: Please review arch/x86/kernel/pvclock.c to fix Docker/Mono crashes in new Kernels

Show all headers | View raw

On Mon, May 16, 2016 at 11:37 AM, Andy Lutomirski <luto@amacapital.net> wrote:
>
> All of those fixes were intended to fix incorrect times being
> reported, not segfaults.  Weird.

I'm assuming it's "time going backwards". I can easily see that
causing segfaults.

I've seen lots of code that timestamps events, and can easily imagine
confusion if the end result is not ordered (ie walking off the
beginning/end of a list or array or similar because the algorithm
"knows" that the events are ordered).

I agree that the original bisection result is a bit questionable, and
it might just be about exposing a timing issue.

                   Linus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: Please review arch/x86/kernel/pvclock.c to fix Docker/Mono  crashes in new Kernels Linus Torvalds <torvalds@linux-foundation.org> - 2016-05-16 20:20 +0200
  Re: Please review arch/x86/kernel/pvclock.c to fix Docker/Mono  crashes in new Kernels Andy Lutomirski <luto@amacapital.net> - 2016-05-16 20:40 +0200
    Re: Please review arch/x86/kernel/pvclock.c to fix Docker/Mono  crashes in new Kernels Linus Torvalds <torvalds@linux-foundation.org> - 2016-05-16 21:00 +0200
      Re: Please review arch/x86/kernel/pvclock.c to fix Docker/Mono  crashes in new Kernels Paolo Bonzini <pbonzini@redhat.com> - 2016-05-17 13:10 +0200

csiph-web