Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1401696
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!feeds.phibee-telecom.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | David Binderman <linuxdev.baldrick@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | linux-4.6/net/kcm/kcmsock.c:1508: bad if test ? |
| Date | Mon, 16 May 2016 20:50:02 +0200 |
| Message-ID | <rzvKy-2cc-11@gated-at.bofh.it> (permalink) |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to; bh=QCrhg/s8HxVHNUW6OCOeX/Y25CqDOer5Lrt1M3pv8Lc=; b=ZYBexK6ClH95tAZwp5lLsCL2lCmodpsPyDHYjy2TU23urt9CSazslfy2RXkcIZLFLb uSB+uoTyl/xjMpUA+D2fhBJdfFtxT3UwfM228AOg/Fwc3rUuvtm+Nyk4GwHCKI0TUpFf ZyXcs9+ohw0lJEbJMtLw7Eli0QFoWTGhn3lzd4aDbXklOTTx4xeJ5FnYDK9oZ/Vd6iOM 7EHA+FFR+zlfRnOFbmTuXtBuRnTpAhfsegWmORwwD2DPgHU2aDNQYPvdfuqljlfAltE6 aPI17qRFd0MpUt6yQMX5tFbpJP4fw4xaM+1mTyDKhcssbbHyfKbXgWUqdYCPQNsgSfY8 qOeQ== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to; bh=QCrhg/s8HxVHNUW6OCOeX/Y25CqDOer5Lrt1M3pv8Lc=; b=Zz1JdZ0iW1EZxPiQ7I0/9FKgakZaWjZx+Q5bSezHFr/HZ2YDlc65ivilSlaS+RBJ5n AUkK+CuEvmUDyqk8FkSsGrNiUdbe6/YkSQFgG9UaDvgv18eR8AG8BPbljQgn02wky5vm f4GpYfA3GNCBdrEuq7iQJNB5Ov5yJ27BAUUT/GfqXKAWSHe/ox9+xt/j3EoMiCjuWHmp 7roRarXzQEB/BNNZbSrEQx7VMCl68boxinl5vrK7dE3uJr6gr7siFNqjrJXtZUXL06hv HRGbGW94pcspp6KJ7zc0Jap+E9GhIrWEFtZCgugbs2cdPMkFJSCi3lfQMxJI2B1NDOQ/ gxrA== |
| X-Gm-Message-State | AOPr4FVDze/9fUme0gPTlOOx2ZbeodCQl/n/kH0YJPNKe6DrFE4/kp4Mnheahd3FPCj/6YoufHgEuY70SI0jPA== |
| MIME-Version | 1.0 |
| X-Received | by 10.107.128.74 with SMTP id b71mr19362398iod.87.1463424043805; Mon, 16 May 2016 11:40:43 -0700 (PDT) |
| Content-Type | text/plain; charset=UTF-8 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 19 |
| Organization | linux.* mail to news gateway |
| X-Original-Date | Mon, 16 May 2016 19:40:43 +0100 |
| X-Original-Message-ID | <CAMzoambRTmpCmM0upiM5PMZtEioSMpw3QB4k--OCvHKmhCnw7w@mail.gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1401696 |
Show key headers only | View raw
Hello there,
linux-4.6/net/kcm/kcmsock.c:1508]: (style) Checking if unsigned
variable 'copied' is less than zero.
Source code is
if (copied < 0) {
but
size_t copied;
Suggest code rework.
Regards
David Binderman
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
linux-4.6/net/kcm/kcmsock.c:1508: bad if test ? David Binderman <linuxdev.baldrick@gmail.com> - 2016-05-16 20:50 +0200
Re: linux-4.6/net/kcm/kcmsock.c:1508: bad if test ? Cong Wang <xiyou.wangcong@gmail.com> - 2016-05-17 18:10 +0200
Re: linux-4.6/net/kcm/kcmsock.c:1508: bad if test ? David Miller <davem@davemloft.net> - 2016-05-17 18:50 +0200
Re: linux-4.6/net/kcm/kcmsock.c:1508: bad if test ? Cong Wang <xiyou.wangcong@gmail.com> - 2016-05-17 19:00 +0200
csiph-web