Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1401673

Re: [PATCH] phy dp83867: depend on CONFIG_OF_MDIO

Show all headers | View raw

On 16.05.16 14:44, Andrew Lunn wrote:
> On Mon, May 16, 2016 at 01:28:15PM +0200, Alexander Graf wrote:
>> The DP83867 phy driver doesn't actually work when CONFIG_OF_MDIO isn't enabled.
>> It simply passes the device tree test, but leaves all internal configuration
>> initialized at 0. Then it configures the phy with those values and renders a
>> previously working configuration useless.
>>
>> This patch makes sure that we only build the DP83867 phy code when
>> CONFIG_OF_MDIO is set, to not run into that problem.
> 
> Hi Alexander
> 
> Looking at the code, the parameters read from device tree are needed
> for RGMII mode. What about the case the PHY is used not in RGMII mode?
> Could it be there are device trees which legitimately don't have these
> properties since they are not needed, and are now going to get
> -ENODEV?

To be honest, I don't know. I only stumbled over this because we compile
all those phy drivers as modules and the driver simply rendered one
system I was working on unusable wrt network.

Dan?


Alex

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] phy dp83867: depend on CONFIG_OF_MDIO Alexander Graf <agraf@suse.de> - 2016-05-16 13:30 +0200
  Re: [PATCH] phy dp83867: depend on CONFIG_OF_MDIO Andrew Lunn <andrew@lunn.ch> - 2016-05-16 14:50 +0200
    Re: [PATCH] phy dp83867: depend on CONFIG_OF_MDIO Alexander Graf <agraf@suse.de> - 2016-05-16 20:00 +0200
  Re: [PATCH] phy dp83867: depend on CONFIG_OF_MDIO Dan Murphy <dmurphy@ti.com> - 2016-05-16 15:40 +0200
    Re: [PATCH] phy dp83867: depend on CONFIG_OF_MDIO Alexander Graf <agraf@suse.de> - 2016-05-16 20:00 +0200
      Re: [PATCH] phy dp83867: depend on CONFIG_OF_MDIO Dan Murphy <dmurphy@ti.com> - 2016-05-16 20:30 +0200

csiph-web