Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1401671

Re: [PATCH] Input: Change BTN_TOOL_FINGER flag when hover event trigger

From Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] Input: Change BTN_TOOL_FINGER flag when hover event trigger
Date 2016-05-16 20:00 +0200
Message-ID <rzuY9-1Ei-5@gated-at.bofh.it> (permalink)
References <rkJFL-3PD-5@gated-at.bofh.it> <rzp2q-6ui-17@gated-at.bofh.it> <rzp2q-6ui-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi Kt,

On Mon, May 16, 2016 at 07:27:25PM +0800, 廖崇榮 wrote:
> 
> Only ABS_DISTANCE is not enough for upper OS to distingiush hover event be
> triggered from object from faraway to and close touchpad surface or from
> object prepare to leave the touchpad surface. Add BTN_TOOL_FINGER flag to
> help it.
> 
>                  object_from_faraway    object_inside_hover_area
> object_touch_surface
> BTN_TOUCH                 0                          0             1
> BTN_TOOL_FINGER           0                          1              1
> ABS_DISTANCE               0                           1             0
> 
> Signed-off by: Duson Lin <dusonlin@emc.com.tw>

I was wondering if we could do without modifying all the drivers that
are using input_mt_report_pointer_emulation(), by figuring out if we
should be emitting BTN_TOOL_FINGER right there:

"If device supports ABS_DISTANCE and does not support ABS_MT_DISTANCE and
ABS_DISTANCE != 0 is reported in current frame and there are no other
contacts then report BTN_TOOL_FINGER."

Thanks.

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Input: Change BTN_TOOL_FINGER flag when hover event trigger 廖崇榮 <kt.liao@emc.com.tw> - 2016-05-16 13:40 +0200
  Re: [PATCH] Input: Change BTN_TOOL_FINGER flag when hover event  trigger Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-05-16 20:00 +0200
    RE: [PATCH] Input: Change BTN_TOOL_FINGER flag when hover event trigger 廖崇榮 <kt.liao@emc.com.tw> - 2016-05-17 16:30 +0200
      Re: [PATCH] Input: Change BTN_TOOL_FINGER flag when hover event  trigger 'Dmitry Torokhov' <dmitry.torokhov@gmail.com> - 2016-05-20 03:00 +0200
        RE: [PATCH] Input: Change BTN_TOOL_FINGER flag when hover event trigger 廖崇榮 <kt.liao@emc.com.tw> - 2016-05-23 16:30 +0200
          Re: [PATCH] Input: Change BTN_TOOL_FINGER flag when hover event  trigger 'Dmitry Torokhov' <dmitry.torokhov@gmail.com> - 2016-05-26 02:30 +0200

csiph-web