Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1401431

[RFC] f2fs: fix a race condition between evict & gc

Show all headers | View raw

When collecting data segment(gc_data_segment), there is a race condition
between evict and phases of gc:
0) ra_node_page(dnode)
1) ra_node_page(inode)
		<--- evict the inode
2) f2fs_iget get the inode and add it to gc_list 
3) move_data_page

In step 2), f2fs_iget does NOT find the inode and allocs a new inode as result,
which is not resonable.

This patch changes f2fs_iget to ilookup. when no inode is found, no new inode is
created.

Signed-off-by: Hou Pengyang <houpengyang@huawei.com>
---
 fs/f2fs/gc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index 38d56f6..6e73193 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -717,8 +717,8 @@ next_step:
 		ofs_in_node = le16_to_cpu(entry->ofs_in_node);
 
 		if (phase == 2) {
-			inode = f2fs_iget(sb, dni.ino);
-			if (IS_ERR(inode) || is_bad_inode(inode))
+			inode = ilookup(sb, dni.ino);
+			if (!inode || IS_ERR(inode) || is_bad_inode(inode))
 				continue;
 
 			/* if encrypted inode, let's go phase 3 */
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[RFC] f2fs: fix a race condition between evict & gc Hou Pengyang <houpengyang@huawei.com> - 2016-05-16 12:50 +0200
  Re: [f2fs-dev] [RFC] f2fs: fix a race condition between evict & gc Chao Yu <chao@kernel.org> - 2016-05-16 17:20 +0200
    Re: [f2fs-dev] [RFC] f2fs: fix a race condition between evict & gc Hou Pengyang <houpengyang@huawei.com> - 2016-05-17 05:10 +0200
      Re: [f2fs-dev] [RFC] f2fs: fix a race condition between evict & gc Jaegeuk Kim <jaegeuk@kernel.org> - 2016-05-17 19:30 +0200
        Re: [f2fs-dev] [RFC] f2fs: fix a race condition between evict & gc Hou Pengyang <houpengyang@huawei.com> - 2016-05-18 13:00 +0200

csiph-web