Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1402548
| From | Thomas Gleixner <tglx@linutronix.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC][WARNING] warning in uncore_pci_probe |
| Date | 2016-05-17 21:40 +0200 |
| Message-ID | <rzT0t-iJ-7@gated-at.bofh.it> (permalink) |
| References | <rzODv-5QT-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, 17 May 2016, Jiri Olsa wrote: > > [ 2.766466] WARNING: CPU: 0 PID: 1 at arch/x86/events/intel/uncore.c:894 uncore_pci_probe+0x2a8/0x2b0 > > I'm booting with nr_cpus=1, which impact physical_to_logical_pkg > setup.. the map will not be initialized because the rest of cpus > is never initialized and set in cpu_present_mask > > it seems to me we should remove the warning, because it's valid to > have only single cpu allowed Single package that is. The package map for cpu 0 is correct, i.e. package 0, but that code tries to init the PCI/uncore for the other packages. So, yes. The WARN_ON() is wrong there. We should just return and be done with it. Thanks, tglx
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC][WARNING] warning in uncore_pci_probe Jiri Olsa <jolsa@redhat.com> - 2016-05-17 17:00 +0200
Re: [RFC][WARNING] warning in uncore_pci_probe Thomas Gleixner <tglx@linutronix.de> - 2016-05-17 21:40 +0200
[PATCH] perf/x86/intel/uncore: Remove WARN_ON_ONCE in uncore_pci_probe Jiri Olsa <jolsa@redhat.com> - 2016-05-18 08:20 +0200
csiph-web