Re: [PATCH] oom: consider multi-threaded tasks in task_will_free_mem

From	Oleg Nesterov <oleg@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] oom: consider multi-threaded tasks in task_will_free_mem
Date	2016-05-17 20:10 +0200
Message-ID	<rzRBo-7V2-21@gated-at.bofh.it> (permalink)
References	<rn2Ej-4JV-23@gated-at.bofh.it> <rnqQi-jn-23@gated-at.bofh.it> <rnsIq-1Gg-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 04/13, Michal Hocko wrote:
>
> On Wed 13-04-16 20:04:54, Tetsuo Handa wrote:
> > On 2016/04/12 18:19, Michal Hocko wrote:
> [...]
> > > Hi,
> > > I hope I got it right but I would really appreciate if Oleg found some
> > > time and double checked after me. The fix is more cosmetic than anything
> > > else but I guess it is worth it.
> >
> > I don't know what
> >
> >     fatal_signal_pending() can be true because of SIGNAL_GROUP_COREDUMP so
> >     out_of_memory() and mem_cgroup_out_of_memory() shouldn't blindly trust it.
> >
> > in commit d003f371b270 is saying (how SIGNAL_GROUP_COREDUMP can make
> > fatal_signal_pending() true when fatal_signal_pending() is defined as
>
> I guess this is about zap_process() but Olge would be more appropriate
> to clarify.


Yes, exactly, the dumper sends SIGKILL to other CLONE_THREAD and/or CLONE_VM
threads.

so I think the patch is fine, but let me write another email...

Oleg.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] oom: consider multi-threaded tasks in task_will_free_mem Oleg Nesterov <oleg@redhat.com> - 2016-05-17 20:10 +0200

csiph-web