Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1402197

Re: [PATCH v2 0/3] cpuacct: Show all detail stats in one file

Show all headers | View raw

* Zhao Lei <zhaolei@cn.fujitsu.com> wrote:

>  1: Rewrite subject and changelog to fix typos and
>     make it more accurate.

So this is really annoying. In the previous review I suggested this:

 " - please fix the title of the patch: have a look at 'git log
     kernel/sched/cpuacct.c' how recent titles to that code look like. "

If you do what I suggested, you see this title:

    sched/cpuacct: Check for NULL when using task_pt_regs()

Yet you continued to submit using the tag I complained about:

    cpuacct: Show all detail stats in one file

Yes, it's a small detail that I could fix up, but this kind of inability to read 
very plain suggestions worries me.

And yes, if I look further, I see further signs of lack of care:

  In current code, we can get cpuacct data from severial files,

severial? How about at least running a spell checker over the text?

... and I haven't even looked at the code.

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/3] cpuacct: Show all detail stats in one file Zhao Lei <zhaolei@cn.fujitsu.com> - 2016-05-13 12:30 +0200
  Re: [PATCH v2 0/3] cpuacct: Show all detail stats in one file Ingo Molnar <mingo@kernel.org> - 2016-05-17 10:40 +0200

csiph-web