Re: mfd: twl-core: Return directly after a failed platform_device_alloc() in add_numbered_child()

From	Lee Jones <lee.jones@linaro.org>
Newsgroups	linux.kernel
Subject	Re: mfd: twl-core: Return directly after a failed platform_device_alloc() in add_numbered_child()
Date	2016-05-17 08:10 +0200
Message-ID	<rzGmB-Pt-5@gated-at.bofh.it> (permalink)
References	(3 earlier) <rzg8O-u7-13@gated-at.bofh.it> <rzkcp-3oC-1@gated-at.bofh.it> <rzkFs-3zx-5@gated-at.bofh.it> <rzlBv-4a7-1@gated-at.bofh.it> <rzlLb-4sk-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 16 May 2016, Julia Lawall wrote:

> On Mon, 16 May 2016, SF Markus Elfring wrote:
> 
> > >> * Change an error message.
> > > 
> > > Why?  Is dev_err needed?
> > 
> > I interpreted Lee's response in this way.
> > https://lkml.org/lkml/2016/1/11/104
> 
> OK.  He didn't ask for the message to be changed though.  It's a bit 
> unfortunate that it now takes up multiple lines.  And I believe it also 
> prints redundant information.  Perhaps he will have some further thoughts 
> on the matter.

Yes, Julia is right.  We normally don't print anything for OOM
errors since Linux reports on them already.

Please remove the print altogether.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Thread

[PATCH 0/2] mfd: twl-core: Fine-tuning for add_numbered_child() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-05-16 04:10 +0200
  [PATCH 1/2] mfd: twl-core: Return directly after a failed  platform_device_alloc() in add_numbered_child() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-05-16 08:30 +0200
    Re: [PATCH 1/2] mfd: twl-core: Return directly after a failed  platform_device_alloc() in add_numbered_child() Julia Lawall <julia.lawall@lip6.fr> - 2016-05-16 09:00 +0200
      Re: mfd: twl-core: Return directly after a failed  platform_device_alloc() in add_numbered_child() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-05-16 10:00 +0200
        Re: mfd: twl-core: Return directly after a failed platform_device_alloc()  in add_numbered_child() Julia Lawall <julia.lawall@lip6.fr> - 2016-05-16 10:10 +0200
          Re: mfd: twl-core: Return directly after a failed  platform_device_alloc() in add_numbered_child() Lee Jones <lee.jones@linaro.org> - 2016-05-17 08:10 +0200
            Re: mfd: twl-core: Return directly after a failed  platform_device_alloc() in add_numbered_child() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-05-17 16:20 +0200
  [PATCH 2/2] mfd: twl-core: Refactoring for add_numbered_child() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-05-16 08:30 +0200

csiph-web