Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1402082

[PATCH 03/10] dma: imx-sdma: clear BD_RROR flag before pass it to sdma script

From Jiada Wang <jiada_wang@mentor.com>
Newsgroups linux.kernel
Subject [PATCH 03/10] dma: imx-sdma: clear BD_RROR flag before pass it to sdma script
Date 2016-05-17 06:00 +0200
Message-ID <rzEkN-7L0-3@gated-at.bofh.it> (permalink)
References <rzEb7-7HI-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Previously in cyclic dma mode when sdma transfer fails for one buffer,
it will mask BD_RROR flag for that buffer descriptor (BD). This flag
won't be cleared unless a new cyclic dma transfer is prepared, so if
sdma script next time iterates to the same BD, even this time the
transfer is successful, but as BD_RROR flag is set, client side
will still think the transfer failed.

This patch clears BD_RROR flag before pass it to sdma script.

Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
---
 drivers/dma/imx-sdma.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index 887e4e5..1489de0 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -671,6 +671,7 @@ static void sdma_handle_channel_loop(struct sdma_channel *sdmac)
 		if (bd->mode.status & BD_RROR)
 			sdmac->status = DMA_ERROR;
 
+		bd->mode.status &= ~BD_RROR;
 		bd->mode.status |= BD_DONE;
 		sdmac->buf_tail++;
 		sdmac->buf_tail %= sdmac->num_bd;
-- 
2.4.5

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH 03/10] dma: imx-sdma: clear BD_RROR flag before pass it to sdma script Jiada Wang <jiada_wang@mentor.com> - 2016-05-17 06:00 +0200

csiph-web