Re: [PATCH v2 1/2] ARM64: dts: rockchip: add sdhci/emmc for rk3399

From	Brian Norris <briannorris@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] ARM64: dts: rockchip: add sdhci/emmc for rk3399
Date	2016-05-13 23:50 +0200
Message-ID	<ryt87-3k7-31@gated-at.bofh.it> (permalink)
References	<ry7qW-737-13@gated-at.bofh.it> <ryt87-3k7-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, May 13, 2016 at 02:42:06PM -0700, Doug Anderson wrote:
> On Thu, May 12, 2016 at 3:35 PM, Brian Norris <briannorris@chromium.org> wrote:
> > +               emmc_phy: phy@f780 {
> > +                       compatible = "rockchip,rk3399-emmc-phy";
> > +                       reg = <0xf780 0x20>;
> 
> This is slightly wrong.  It should be:
> 
> reg = <0xf780 0x24>;
> 
> The status register is at an offset of 0x20 and is 4 bytes big, so we
> need room for it.

Fixed.

> After that is fixed, feel free to add my Reviewed-by tag.

Done.

Thanks for the review.

Brian

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] ARM64: dts: rockchip: add sdhci/emmc for rk3399 Brian Norris <briannorris@chromium.org> - 2016-05-13 00:40 +0200
  [PATCH v2 2/2] ARM64: dts: rockchip: enable eMMC for rk3399 EVB Brian Norris <briannorris@chromium.org> - 2016-05-13 00:40 +0200
    Re: [PATCH v2 2/2] ARM64: dts: rockchip: enable eMMC for rk3399 EVB Heiko Stuebner <heiko@sntech.de> - 2016-05-14 00:00 +0200
  Re: [PATCH v2 1/2] ARM64: dts: rockchip: add sdhci/emmc for rk3399 Shawn Lin <shawn.lin@rock-chips.com> - 2016-05-13 02:50 +0200
  Re: [PATCH v2 1/2] ARM64: dts: rockchip: add sdhci/emmc for rk3399 Heiko Stuebner <heiko@sntech.de> - 2016-05-13 23:50 +0200
    Re: [PATCH v2 1/2] ARM64: dts: rockchip: add sdhci/emmc for rk3399 Brian Norris <briannorris@chromium.org> - 2016-05-14 00:00 +0200
      Re: [PATCH v2 1/2] ARM64: dts: rockchip: add sdhci/emmc for rk3399 Heiko Stuebner <heiko@sntech.de> - 2016-05-14 00:20 +0200
  Re: [PATCH v2 1/2] ARM64: dts: rockchip: add sdhci/emmc for rk3399 Doug Anderson <dianders@chromium.org> - 2016-05-13 23:50 +0200
    Re: [PATCH v2 1/2] ARM64: dts: rockchip: add sdhci/emmc for rk3399 Brian Norris <briannorris@chromium.org> - 2016-05-13 23:50 +0200

csiph-web