Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1400922
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH 2/2] Documentation: devictree: Add macb mdio bindings |
| Date | 2016-05-13 19:50 +0200 |
| Message-ID | <rypnP-8fB-3@gated-at.bofh.it> (permalink) |
| References | <ryhTk-Lw-7@gated-at.bofh.it> <ryhTk-Lw-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Harini
Is this backward compatible? Will devices using the old binding still
work?
/* Disable RX and TX (XXX: Should we halt the transmission
* more gracefully?)
*/
- macb_writel(bp, NCR, 0);
+ ctrl = macb_readl(bp, NCR);
+ ctrl &= ~(MACB_BIT(RE) | MACB_BIT(TE));
+ macb_writel(bp, NCR, ctrl);
/* Clear the stats registers (XXX: Update stats first?) */
- macb_writel(bp, NCR, MACB_BIT(CLRSTAT));
+ ctrl |= MACB_BIT(CLRSTAT);
+ macb_writel(bp, NCR, ctrl);
/* Clear all status flags */
macb_writel(bp, TSR, -1);
It is not clear to me what this part has to do with MDIO.
Andrew
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC PATCH 2/2] Documentation: devictree: Add macb mdio bindings Harini Katakam <harini.katakam@xilinx.com> - 2016-05-13 11:50 +0200
Re: [RFC PATCH 2/2] Documentation: devictree: Add macb mdio bindings Andrew Lunn <andrew@lunn.ch> - 2016-05-13 19:40 +0200
Re: [RFC PATCH 2/2] Documentation: devictree: Add macb mdio bindings Andrew Lunn <andrew@lunn.ch> - 2016-05-13 19:50 +0200
Re: [RFC PATCH 2/2] Documentation: devictree: Add macb mdio bindings Harini Katakam <harinikatakamlinux@gmail.com> - 2016-05-14 05:00 +0200
csiph-web