Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1400786
| From | Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [patch net-next 06/11] ACPI: bus: move acpi_match_device_ids() to linux/acpi.h |
| Date | 2016-05-13 15:20 +0200 |
| Message-ID | <rylax-3Vi-11@gated-at.bofh.it> (permalink) |
| References | <rygkx-7Xv-3@gated-at.bofh.it> <rygky-7Xv-11@gated-at.bofh.it> |
| Organization | Intel Finland Oy |
On Fri, 2016-05-13 at 16:19 +0800, Yisen Zhuang wrote: > From: Hanjun Guo <hanjun.guo@linaro.org> > > acpi_match_device_ids() will be used for drivers to match > different hardware versions, it will be compiled in non-ACPI > case, but acpi_match_device_ids() in acpi_bus.h and it can > only be used in ACPI case, so move it to linux/acpi.h and > introduce a stub function for it. I somehow doubt this is right move. Like I said in the previous comment the architectural split might make this a bit better. You might use #ifdef IS_ENABLED(CONFIG_ACPI) #else #endif only once to some big part of code. If kernel is build without ACPI support you even will not have this in your driver at all. -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[patch net-next 06/11] ACPI: bus: move acpi_match_device_ids() to linux/acpi.h Yisen Zhuang <Yisen.Zhuang@huawei.com> - 2016-05-13 10:10 +0200
Re: [patch net-next 06/11] ACPI: bus: move acpi_match_device_ids() to linux/acpi.h Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-05-13 15:20 +0200
Re: [patch net-next 06/11] ACPI: bus: move acpi_match_device_ids() to linux/acpi.h "Yankejian (Hackim Yim)" <yankejian@huawei.com> - 2016-05-16 04:10 +0200
csiph-web