Re: [PATCH v3] usb: dwc2: fix regression on big-endian PowerPC/ARM systems

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] usb: dwc2: fix regression on big-endian PowerPC/ARM systems
Date	2016-05-13 15:50 +0200
Message-ID	<rylDA-4eO-23@gated-at.bofh.it> (permalink)
References	<ry5S9-4Z1-3@gated-at.bofh.it> <ryeVs-6bm-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thursday 12 May 2016 23:32:18 John Youn wrote:
> 
> Hi Arnd,
> 
> The capitalization issue is still there in this patch.
> 
> There's also a few checkpatch issues.

Fixed now, thanks. I'll send a v4 in a bit.

> And should the barrier be moved after the write like it says in the
> comment? That seems to have been removed since earlier versions of
> the patch.

I've clarified the comment, so we refer to the __raw_writel
not the writel. It's also possible that this was just another
bug in the patch that broke powerpc, but I don't know anything
about MIPS barrier semantics, so I prefer not to touch that.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] usb: dwc2: fix regression on big-endian PowerPC/ARM systems Arnd Bergmann <arnd@arndb.de> - 2016-05-12 23:00 +0200
  Re: [PATCH v3] usb: dwc2: fix regression on big-endian PowerPC/ARM  systems John Youn <John.Youn@synopsys.com> - 2016-05-13 08:40 +0200
    Re: [PATCH v3] usb: dwc2: fix regression on big-endian PowerPC/ARM systems Arnd Bergmann <arnd@arndb.de> - 2016-05-13 15:50 +0200

csiph-web