Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1400747
| From | Michal Hocko <mhocko@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC 06/13] mm, thp: remove __GFP_NORETRY from khugepaged and madvised allocations |
| Date | 2016-05-13 14:10 +0200 |
| Message-ID | <ryk4P-2Yo-37@gated-at.bofh.it> (permalink) |
| References | <rxaqR-6fU-5@gated-at.bofh.it> <rxaqR-6fU-13@gated-at.bofh.it> <ry1ER-17c-1@gated-at.bofh.it> <rygDU-89l-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri 13-05-16 10:23:31, Vlastimil Babka wrote: > On 05/12/2016 06:20 PM, Michal Hocko wrote: > > On Tue 10-05-16 09:35:56, Vlastimil Babka wrote: > > [...] > > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > > > index 570383a41853..0cb09714d960 100644 > > > --- a/include/linux/gfp.h > > > +++ b/include/linux/gfp.h > > > @@ -256,8 +256,7 @@ struct vm_area_struct; > > > #define GFP_HIGHUSER (GFP_USER | __GFP_HIGHMEM) > > > #define GFP_HIGHUSER_MOVABLE (GFP_HIGHUSER | __GFP_MOVABLE) > > > #define GFP_TRANSHUGE ((GFP_HIGHUSER_MOVABLE | __GFP_COMP | \ > > > - __GFP_NOMEMALLOC | __GFP_NORETRY | __GFP_NOWARN) & \ > > > - ~__GFP_RECLAIM) > > > + __GFP_NOMEMALLOC | __GFP_NOWARN) & ~__GFP_RECLAIM) > > > > I am not sure this is the right thing to do. I think we should keep > > __GFP_NORETRY and clear it where we want a stronger semantic. This is > > just too suble that all callsites are doing the right thing. > > That would complicate alloc_hugepage_direct_gfpmask() a bit, but if you > think it's worth it, I can turn the default around, OK. Hmm, on the other hand it is true that GFP_TRANSHUGE is clearing both reclaim flags by default and then overwrites that. This is just too ugly. Can we make GFP_TRANSHUGE to only define flags we care about and then tweak those that should go away at the callsites which matter now that we do not rely on is_thp_gfp_mask? -- Michal Hocko SUSE Labs
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [RFC 06/13] mm, thp: remove __GFP_NORETRY from khugepaged and madvised allocations Michal Hocko <mhocko@kernel.org> - 2016-05-12 18:30 +0200
Re: [RFC 06/13] mm, thp: remove __GFP_NORETRY from khugepaged and madvised allocations Vlastimil Babka <vbabka@suse.cz> - 2016-05-13 10:30 +0200
Re: [RFC 06/13] mm, thp: remove __GFP_NORETRY from khugepaged and madvised allocations Michal Hocko <mhocko@kernel.org> - 2016-05-13 14:10 +0200
Re: [RFC 06/13] mm, thp: remove __GFP_NORETRY from khugepaged and madvised allocations Vlastimil Babka <vbabka@suse.cz> - 2016-05-18 14:10 +0200
Re: [RFC 06/13] mm, thp: remove __GFP_NORETRY from khugepaged and madvised allocations Michal Hocko <mhocko@kernel.org> - 2016-05-18 17:30 +0200
Re: [RFC 06/13] mm, thp: remove __GFP_NORETRY from khugepaged and madvised allocations Vlastimil Babka <vbabka@suse.cz> - 2016-05-20 16:00 +0200
Re: [RFC 06/13] mm, thp: remove __GFP_NORETRY from khugepaged and madvised allocations Michal Hocko <mhocko@kernel.org> - 2016-05-23 10:40 +0200
csiph-web