Re: [tip:sched/core] sched/fair: Clean up scale confusion

From	Yuyang Du <yuyang.du@intel.com>
Newsgroups	linux.kernel
Subject	Re: [tip:sched/core] sched/fair: Clean up scale confusion
Date	2016-05-13 05:30 +0200
Message-ID	<rybXA-2Zx-3@gated-at.bofh.it> (permalink)
References	<rybXA-2Zx-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, May 12, 2016 at 03:31:27AM -0700, tip-bot for Peter Zijlstra wrote:
> Commit-ID:  1be0eb2a97d756fb7dd8c9baf372d81fa9699c09
> Gitweb:     http://git.kernel.org/tip/1be0eb2a97d756fb7dd8c9baf372d81fa9699c09
> Author:     Peter Zijlstra <peterz@infradead.org>
> AuthorDate: Fri, 6 May 2016 12:21:23 +0200
> Committer:  Ingo Molnar <mingo@kernel.org>
> CommitDate: Thu, 12 May 2016 09:55:33 +0200
> 
> sched/fair: Clean up scale confusion
> 
> Wanpeng noted that the scale_load_down() in calculate_imbalance() was
> weird. I agree, it should be SCHED_CAPACITY_SCALE, since we're going
> to compare against busiest->group_capacity, which is in [capacity]
> units.
>
> Reported-by: Wanpeng Li <wanpeng.li@hotmail.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Mike Galbraith <efault@gmx.de>
> Cc: Morten Rasmussen <morten.rasmussen@arm.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Yuyang Du <yuyang.du@intel.com>
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Ingo Molnar <mingo@kernel.org>

It is good that this issue is addressed and patch merged, however, for the
record, Vincent has already had a solution for this, and we had a patch,
including other cleanups (the latest version is: https://lkml.org/lkml/2016/5/3/925).
And I think Ben first pointed this out (and we then attempted to address it)
as far as I can tell.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [tip:sched/core] sched/fair: Clean up scale confusion Yuyang Du <yuyang.du@intel.com> - 2016-05-13 05:30 +0200
  Re: [tip:sched/core] sched/fair: Clean up scale confusion Vincent Guittot <vincent.guittot@linaro.org> - 2016-05-13 09:30 +0200
    Re: [tip:sched/core] sched/fair: Clean up scale confusion Morten Rasmussen <morten.rasmussen@arm.com> - 2016-05-20 12:20 +0200
      Re: [tip:sched/core] sched/fair: Clean up scale confusion Vincent Guittot <vincent.guittot@linaro.org> - 2016-05-23 12:30 +0200

csiph-web