Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1400471

Re: [PATCH 1/2] cpufreq: governor: CPUFREQ_GOV_POLICY_EXIT never fails

From Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] cpufreq: governor: CPUFREQ_GOV_POLICY_EXIT never fails
Date 2016-05-13 05:20 +0200
Message-ID <rybNT-2U0-9@gated-at.bofh.it> (permalink)
References <rxYH0-6wa-15@gated-at.bofh.it> <rxYH0-6wa-31@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 12-05-16, 15:13, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> None of the cpufreq governors currently in the tree will ever fail
> an invocation of the ->governor() callback with the event argument
> equal to CPUFREQ_GOV_POLICY_EXIT (unless invoked with incorrect
> arguments which doesn't matter anyway) and it wouldn't really
> make sense to fail it, because the caller won't be able to handle
> that failure in a meaningful way.
> 
> Accordingly, rearrange the code in the core to make it clear that
> this call never fails.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>  drivers/cpufreq/cpufreq.c |   35 ++++++++++++-----------------------
>  1 file changed, 12 insertions(+), 23 deletions(-)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] cpufreq: governor: CPUFREQ_GOV_POLICY_EXIT never fails "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-05-12 15:20 +0200
  Re: [PATCH 1/2] cpufreq: governor: CPUFREQ_GOV_POLICY_EXIT never  fails Viresh Kumar <viresh.kumar@linaro.org> - 2016-05-13 05:20 +0200

csiph-web